Feature branch for Show on App Launch #4944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
3 tasks
This was referenced Aug 28, 2024
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
1f3b960
to
5dbdb61
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
2 times, most recently
from
8e2a56f
to
67fbe46
Compare
55 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
67fbe46
to
b5bd938
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
3 times, most recently
from
55cc562
to
18e7233
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
18e7233
to
098626f
Compare
12 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
098626f
to
bbdbaa4
Compare
5 tasks
10 tasks
51 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
42c5105
to
6d587a7
Compare
This was referenced Oct 21, 2024
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
a51844e
to
ee931e7
Compare
4 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
e4a53b2
to
502b5cb
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
2233422
to
6333b47
Compare
11 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
9297554
to
8866941
Compare
6 tasks
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709078/f Adds the “Show on App Launch” entry point in the General settings screen. We will likely not use a `String` to determine the secondary text but this makes it easier for step by step implementation. [Designs](https://www.figma.com/design/N2GbF5HEvopp5iwmAlMwyD/New-Tab-Page-Customization?node-id=1741-64494&t=SpS14wACEtPydb2z-4) - [x] Open settings - [x] Click “General” - [x] Check “Show on App Launch” is bottom of the list | Before | After | | ------ | ----- | |  |  | --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
Task/Issue URL: https://app.asana.com/0/1205782002757341/1208523107235076/f Adds a feature toggle for the Show on App Launch feature that defaults to on. - [x] Open General Settings - [x] Check Show on App Launch button is visible - [x] Open FF Inventory - [x] Disable `showOnAppLaunch` - [x] Open General Settings - [x] Check Show on App Launch button is gone - [x] Open FF Inventory - [x] Enable `showOnAppLaunch` - [x] Open General Settings - [x] Check Show on App Launch button is visible N/A
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208637287651029/f ### Description Fixes no options being selected then the phone is rotated. ### Steps to test this PR - [x] Open Show on App Launch screen in settings - [x] Rotate phone to landscape - [x] The same option that was selected should still be selected ### Demo https://github.com/user-attachments/assets/2fabd7ae-15c5-41e6-8b04-c78c13483d71
# app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt # app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt # app/src/main/res/layout/activity_show_on_app_launch_setting.xml
…#5236) Task/Issue URL: https://app.asana.com/0/1207908166761516/1208685892092430/f ### Description - Disables Specific Url EditText if it Specific Url is not selected using updated disabled state from DS - Saves user input for Specific Url when switching options ### Steps to test this PR - [x] Open Show on App Launch screen - [x] If Specific Url is selected change option - [x] Check the Specific Url EditText is now in the [disabled state](https://www.figma.com/design/BOHDESHODUXK7wSRNBOHdu/%F0%9F%A4%96-Android-Components?node-id=14783-11394&t=NMEXm3w5UWt3iiPQ-4) - [x] Select Specific Url - [x] Change the url - [x] Select a new option - [x] Check that the url you entered has not changed - [x] Select Specific Url - [x] Delete the url - [x] Press the up button - [x] Check that the default url appears -> "https://duckduckgo.com" on the general settings screen ### UI changes https://github.com/user-attachments/assets/92158d39-9ddc-43b0-81f3-77017a8ce767
Task/Issue URL: https://app.asana.com/0/488551667048375/1208705964260532/f ### Description Defaults the feature toggle to off. I will raise a PR to add this to the remote config. ### Steps to test this PR - [ ] Go to General section of Settings screen - [ ] Check "Show on App Launch" is not visible - [ ] Open Feature Flag Inventory screen - [ ] Enable `showOnAppLaunch` - [ ] Go to General section of Settings screen - [ ] Check "Show on App Launch" is visible ### UI changes N/A
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/implementation
branch
from
cb0f850
to
f40738e
Compare
mikescamell
deleted the
feature/mike/show-on-app-launch/implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208167186867401/f
Description
This is the feature branch for the implementation of https://app.asana.com/0/1207908166761516/1207644558291046/f
Steps to test this PR
See stacked PRs.