Show on App Launch: Setting screen #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @mikescamell and the rest of your teammates on |
3 tasks
mikescamell
changed the title
6 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
caac36c
to
8a52cd9
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
ae25d85
to
ee176b3
Compare
|
We’ve now updated the behaviour to always show the url entry box on the screen and the url will be selected when chosen for easier deletion Note: I’m aware that the word “URL” in the url EditText is wrong but this will be fixed in #4952 Screen_recording_20240902_154138.webm |
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
6e63612
to
e558e19
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
8a52cd9
to
164c074
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
e558e19
to
e4c4564
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
164c074
to
781ef4a
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
e4c4564
to
c752e32
Compare
55 tasks
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
781ef4a
to
46c9f4f
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
c752e32
to
70a1018
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
46c9f4f
to
9a079f6
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
70a1018
to
dbd89dc
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
9a079f6
to
bb0c0a8
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
dbd89dc
to
c5b72b5
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
bb0c0a8
to
fb3e506
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
c5b72b5
to
a89a4bc
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
fb3e506
to
17bae85
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
a89a4bc
to
f2ea3c2
Compare
12 tasks
We'll move RadioListItem out of the geoswitching module next as we're using this in multiple places
I added in the onOptionsItemSelected for the up button as I noticed that while we fade into the Activity, we do not fade when pressing back buy slide. This stops this does the fade animation.
I needed to add a setChecked function to the RadioListItem as it didn't exist and we need to be able to clear sections I opted to clear everything when a selection is made to make things easier
as we have a whole screen for this setting we've decided to make the specific page url always visible when the user selects specific page then we highlight all the text making it easier for them to delete it we'll fix the fact that the url does not populate in the branch feature/mike/show-on-app-launch/add-persistence as this is where changes around observing state were made
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/general-settings-entry-point
branch
from
17bae85
to
03f047d
Compare
mikescamell
force-pushed
the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
from
f2ea3c2
to
4db2c4b
Compare
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709085/f ### Description Adds persistence via datastore and observes the changes in the General settings screen and the ShowOnAppLaunch settings screen ### Steps to test this PR - [x] Open General settings - [x] Check current value of “Show on App Launch” secondary text - [x] Open “Show on App Launch” - [x] Change option - [x] Go back to General settings - [x] Check the updated secondary matches your option. In the case of “Specific Page” it will be the url **Note**: There’s no validation and storage of an updated “Specific Page” in this PR. That will be in a future PR. ### UI changes [persistence_demo.webm](https://github.com/user-attachments/assets/236ed58d-81af-4838-9749-b19af98b006c) --------- Co-authored-by: Marcos Holgado <marcosh@duckduckgo.com> Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
mikescamell
merged commit 811fdf5
into
feature/mike/show-on-app-launch/general-settings-entry-point
3 of 5 checks passed
mikescamell
deleted the
feature/mike/show-on-app-launch/show-on-app-launch-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208156273709081/f
Description
Adds the UI for the Show on App Launch settings screen and allows switching options. Nothing is stored and no validation.
I moved RadioListItem to the
common-uimodule seeing as it’s now being used in multiple places.Designs
Steps to test this PR
UI changes
Screen_recording_20240828_162354.webm