Omnibar position: Privacy popup dialog #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2024
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-snackbar
branch
from
0a36e19
to
092ca7b
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-position-privacy-popup
branch
from
27f44e6
to
e41d26d
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-snackbar
branch
from
092ca7b
to
023cb42
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-position-privacy-popup
branch
from
e41d26d
to
400823e
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-snackbar
branch
from
023cb42
to
eaf76a1
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-position-privacy-popup
branch
from
400823e
to
1b4d7ee
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-snackbar
branch
from
eaf76a1
to
84e6365
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-position-privacy-popup
branch
from
1b4d7ee
to
c371e1d
Compare
This reverts commit fdfaa4f.
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-snackbar
branch
from
84e6365
to
07f9238
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-position-privacy-popup
branch
from
c371e1d
to
fed3685
Compare
Base automatically changed from
feature/ondrej/omnibar-bottom-snackbar
to
feature/ondrej/omnibar-position
September 9, 2024 15:50
…nibar-position-privacy-popup # Conflicts: # app/src/main/java/com/duckduckgo/app/cta/ui/Cta.kt # app/src/test/java/com/duckduckgo/app/cta/ui/CtaTest.kt
0nko
added a commit
that referenced
this pull request
Sep 9, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208184077971807/f ### Description ### Steps to test this PR - [ ] Go to settings and change the omnibar position to BOTTOM - [ ] Go back to the tab - [ ] Trigger the privacy popup condition - [ ] Notice the dialog correctly appears at the bottom ### UI changes | Before | After | | ------ | ----- | ||
0nko
added a commit
that referenced
this pull request
Sep 12, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208184077971807/f ### Description ### Steps to test this PR - [ ] Go to settings and change the omnibar position to BOTTOM - [ ] Go back to the tab - [ ] Trigger the privacy popup condition - [ ] Notice the dialog correctly appears at the bottom ### UI changes | Before | After | | ------ | ----- | ||
0nko
added a commit
that referenced
this pull request
Sep 17, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208184077971807/f ### Description ### Steps to test this PR - [ ] Go to settings and change the omnibar position to BOTTOM - [ ] Go back to the tab - [ ] Trigger the privacy popup condition - [ ] Notice the dialog correctly appears at the bottom ### UI changes | Before | After | | ------ | ----- | ||
0nko
added a commit
that referenced
this pull request
Sep 19, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208184077971807/f ### Description ### Steps to test this PR - [ ] Go to settings and change the omnibar position to BOTTOM - [ ] Go back to the tab - [ ] Trigger the privacy popup condition - [ ] Notice the dialog correctly appears at the bottom ### UI changes | Before | After | | ------ | ----- | ||
0nko
added a commit
that referenced
this pull request
Sep 19, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208184077971807/f ### Description ### Steps to test this PR - [ ] Go to settings and change the omnibar position to BOTTOM - [ ] Go back to the tab - [ ] Trigger the privacy popup condition - [ ] Notice the dialog correctly appears at the bottom ### UI changes | Before | After | | ------ | ----- | ||
0nko
added a commit
that referenced
this pull request
Sep 23, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208184077971807/f ### Description ### Steps to test this PR - [ ] Go to settings and change the omnibar position to BOTTOM - [ ] Go back to the tab - [ ] Trigger the privacy popup condition - [ ] Notice the dialog correctly appears at the bottom ### UI changes | Before | After | | ------ | ----- | ||
0nko
added a commit
that referenced
this pull request
Sep 23, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208184077971807/f ### Description ### Steps to test this PR - [ ] Go to settings and change the omnibar position to BOTTOM - [ ] Go back to the tab - [ ] Trigger the privacy popup condition - [ ] Notice the dialog correctly appears at the bottom ### UI changes | Before | After | | ------ | ----- | ||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208184077971807/f
Description
Steps to test this PR
UI changes