Omnibar position: Pixels #4974
Merged
Omnibar position: Pixels #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 2, 2024
Merged
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0nko
force-pushed
the
feature/ondrej/omnibar-position-privacy-popup
branch
from
1b4d7ee
to
c371e1d
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-pixels
branch
from
aaeccf4
to
b960ce7
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-position-privacy-popup
branch
from
c371e1d
to
fed3685
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-pixels
branch
from
b960ce7
to
e604cb8
Compare
Base automatically changed from
feature/ondrej/omnibar-position-privacy-popup
to
feature/ondrej/omnibar-position
September 9, 2024 15:59
0nko
force-pushed
the
feature/ondrej/omnibar-position
branch
from
40ecd9e
to
b0dd837
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-pixels
branch
2 times, most recently
from
18e9284
to
0a11291
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-position
branch
from
7bd0bd1
to
cd4a537
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-pixels
branch
3 times, most recently
from
97184fd
to
54be351
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-pixels
branch
from
54be351
to
415a983
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-position
branch
from
1672676
to
37114ff
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-pixels
branch
from
415a983
to
518ff2b
Compare
Task/Issue URL: https://app.asana.com/0/0/1208157864474373/f ### Description ### Steps to test this PR - [ ] Start the omnibar at the top - [ ] Reload the page and notice the dummy toolbar is shown at the top - [ ] Change the omnibar to the bottom - [ ] Reload the page and notice the dummy toolbar is shown at the bottom
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208166986247266/f - [ ] Change the omnibar position to the bottom - [ ] Start typing in the address bar - [ ] Notice the suggestions are correctly displayed above the toolbar | Before | After | | ------ | ----- | ||
0nko
force-pushed
the
feature/ondrej/omnibar-position
branch
from
37114ff
to
3864a65
Compare
0nko
force-pushed
the
feature/ondrej/omnibar-bottom-pixels
branch
from
518ff2b
to
589e086
Compare
0nko
added a commit
that referenced
this pull request
Sep 19, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208145303592222/f ### Description This PR implements a new plugin that allows the `m_browser_feature_daily_active_user_d` pixel to collect additional parameters from different parts of the app. This is used to report the omnibar position. ### Steps to test this PR _Omnibar position selection_ - [x] Go to Settings -> Appearance - [x] Tap on the Address bar option - [x] Verify that `ms_address_bar_position_setting_pressed` pixel is fired - [x] Select the Top option - [x] Verify that `ms_address_bar_position_setting_selected_top` pixel is fired - [x] Tap on the address bar again - [x] Select the Bottom option - [x] Verify that `ms_address_bar_position_setting_selected_bottom` pixel is fired _Omnibar position detection_ - [x] Uninstall the app, if already installed - [x] Run the app - [x] Verify that`m_browser_feature_daily_active_user_d` pixel is fired with params: `{default_browser=0, email=0, voice_search=0, address_bar=[[CURRENT OMNIBAR POSITION]], locale=en-US}` with the correct position
0nko
added a commit
that referenced
this pull request
Sep 23, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208145303592222/f ### Description This PR implements a new plugin that allows the `m_browser_feature_daily_active_user_d` pixel to collect additional parameters from different parts of the app. This is used to report the omnibar position. ### Steps to test this PR _Omnibar position selection_ - [x] Go to Settings -> Appearance - [x] Tap on the Address bar option - [x] Verify that `ms_address_bar_position_setting_pressed` pixel is fired - [x] Select the Top option - [x] Verify that `ms_address_bar_position_setting_selected_top` pixel is fired - [x] Tap on the address bar again - [x] Select the Bottom option - [x] Verify that `ms_address_bar_position_setting_selected_bottom` pixel is fired _Omnibar position detection_ - [x] Uninstall the app, if already installed - [x] Run the app - [x] Verify that`m_browser_feature_daily_active_user_d` pixel is fired with params: `{default_browser=0, email=0, voice_search=0, address_bar=[[CURRENT OMNIBAR POSITION]], locale=en-US}` with the correct position
0nko
added a commit
that referenced
this pull request
Sep 23, 2024
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208145303592222/f ### Description This PR implements a new plugin that allows the `m_browser_feature_daily_active_user_d` pixel to collect additional parameters from different parts of the app. This is used to report the omnibar position. ### Steps to test this PR _Omnibar position selection_ - [x] Go to Settings -> Appearance - [x] Tap on the Address bar option - [x] Verify that `ms_address_bar_position_setting_pressed` pixel is fired - [x] Select the Top option - [x] Verify that `ms_address_bar_position_setting_selected_top` pixel is fired - [x] Tap on the address bar again - [x] Select the Bottom option - [x] Verify that `ms_address_bar_position_setting_selected_bottom` pixel is fired _Omnibar position detection_ - [x] Uninstall the app, if already installed - [x] Run the app - [x] Verify that`m_browser_feature_daily_active_user_d` pixel is fired with params: `{default_browser=0, email=0, voice_search=0, address_bar=[[CURRENT OMNIBAR POSITION]], locale=en-US}` with the correct position
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208145303592222/f
Description
This PR implements a new plugin that allows the
m_browser_feature_daily_active_user_dpixel to collect additional parameters from different parts of the app. This is used to report the omnibar position.Steps to test this PR
Omnibar position selection
ms_address_bar_position_setting_pressedpixel is firedms_address_bar_position_setting_selected_toppixel is firedms_address_bar_position_setting_selected_bottompixel is firedOmnibar position detection
m_browser_feature_daily_active_user_dpixel is fired with params:{default_browser=0, email=0, voice_search=0, address_bar=[[CURRENT OMNIBAR POSITION]], locale=en-US}with the correct position