Re-enable autofill in iFrames #5007
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @cmonfortep and the rest of your teammates on |
cmonfortep
force-pushed
the
feature/cristian/autofill/bring_back_autofill_new_api
branch
from
81aaf44
to
3d9e19e
Compare
cmonfortep
commented
Sep 13, 2024
| """.trimIndent() | ||
| } | ||
|
|
||
| // TODO: we need to put back "unknown_username_categorization": $unknownUsernameCategorization" into JSON. |
There was a problem hiding this comment.
MUST DO before merging PR into develop
There was a problem hiding this comment.
I enabled it locally, and autofill seems to work fine!
…m" (while solving conflicts) Use old DuckDuckGo-Autofill JS for testing new apis
cmonfortep
force-pushed
the
feature/cristian/autofill/bring_back_autofill_new_api
branch
from
f2a420b
to
97c11b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208302312668360/f
Description
Steps to test this PR
Feature 1
UI changes