[Android] Re-introduce autofill in iframe #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbajpeyi
force-pushed
the
dbajpeyi/reintroduce-autofill-in-iframes
branch
from
cebe077
to
b0eb76c
Compare
dbajpeyi
changed the title
dbajpeyi
changed the title
GioSensation
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/1205996472158114/1208236187388611/f
Description
Autofill was enabled for iframe in android, but later reverted, due to a bug in webview.
The bug is now fixed in the webview, and we're planning to bring back autofill.js in iframes, in android.
Android PR: duckduckgo/Android#5007
Steps to test
feature/cristian/autofill/bring_back_autofill_new_apion android repo