android: Revert "Android: enable iframe support (#536)" #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8b046b1, disabling Android iframe support due to a bug in the native WebView. See https://app.asana.com/0/1203822806345703/1207304124810216/f for details.
sjbarag
force-pushed
the
sbarag/disable-android-iframe-support
branch
from
0ff72f6
to
573731e
Compare
|
For posterity: this was a simple |
|
All working fine on the Android side |
GioSensation
approved these changes
Jun 20, 2024
This was referenced Jun 20, 2024
sjbarag
added a commit
that referenced
this pull request
Jun 21, 2024
This was originally introduced as a commit squashed into 8b046b1 (Android: enable iframe support (#536), 2024-04-09), but was accidentally removed via 18dd599 (android: revert "Android: enable iframe support (#536)" (#582), 2024-06-20). Reintroduce that commit, to ensure the `password_generation` runtime config flag is again respected and prevent password prompts after a user clicks "Never save for site". (cherry picked from commit 4c16e52)
sjbarag
added a commit
that referenced
this pull request
Jun 21, 2024
This was originally introduced as a commit squashed into 8b046b1 (Android: enable iframe support (#536), 2024-04-09), but was accidentally removed via 18dd599 (android: revert "Android: enable iframe support (#536)" (#582), 2024-06-20). Reintroduce that commit, to ensure the `password_generation` runtime config flag is again respected and prevent password prompts after a user clicks "Never save for site". (cherry picked from commit 4c16e52)
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Jun 21, 2024
Task/Issue URL: https://app.asana.com/0/1207623126907992/1207623126907992 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.0.0 ## Description Updates Autofill to version [12.0.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.0.0). ### Autofill 12.0.0 release notes * Major version bump to 12.0.0 caused by #396, which impacts only Android. * This release also translates the autofill experience to the following language codes: * bg * cs * da * de * el * en * es * et * fi * fr * hr * hu * it * lt * lv * nb * nl * pl * pt * ro * ru * sk * sl * sv * tr ## What's Changed * Ema/more minor fixes by @GioSensation in duckduckgo/duckduckgo-autofill#556 * l10n: extract remaining strings to prepare for localization by @sjbarag in duckduckgo/duckduckgo-autofill#558 * l10n: pull translated strings into separate JSON files by @sjbarag in duckduckgo/duckduckgo-autofill#559 * Update password-related json files (2024-05-13) by @daxmobile in duckduckgo/duckduckgo-autofill#561 * Update password-related json files (2024-05-19) by @daxmobile in duckduckgo/duckduckgo-autofill#569 * vcs: ignore .helix directory by @sjbarag in duckduckgo/duckduckgo-autofill#565 * l10n: remove placeholder from 'Manage ${ITEM}…' string by @sjbarag in duckduckgo/duckduckgo-autofill#560 * real-world: remove expected failure from clientssp.fnfis.com test by @sjbarag in duckduckgo/duckduckgo-autofill#563 * real-world: remove expected failure for agile.appian.com by @sjbarag in duckduckgo/duckduckgo-autofill#567 * autofill: left-align HTML autofill buttons by @sjbarag in duckduckgo/duckduckgo-autofill#571 * l10n: add translated messages by @sjbarag in duckduckgo/duckduckgo-autofill#572 * passwords: require a digit in passwords generated from default rules by @sjbarag in duckduckgo/duckduckgo-autofill#562 * classifiers: fix another batch of test page expected username failures by @sjbarag in duckduckgo/duckduckgo-autofill#573 * Update password-related json files (2024-05-30) by @daxmobile in duckduckgo/duckduckgo-autofill#577 * Update password-related json files (2024-05-31) by @daxmobile in duckduckgo/duckduckgo-autofill#578 * l10n: update translations based on ship review feedback by @sjbarag in duckduckgo/duckduckgo-autofill#581 * android: Revert "Android: enable iframe support (#536)" by @sjbarag in duckduckgo/duckduckgo-autofill#582 ## New Contributors * @sjbarag made their first contribution in duckduckgo/duckduckgo-autofill#558 **Full Changelog**: duckduckgo/duckduckgo-autofill@11.0.2...12.0.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: sjbarag <665775+sjbarag@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @GioSensation
Asana: https://app.asana.com/0/1203822806345703/1207304124810216/f
Description
This reverts commit 8b046b1, disabling Android iframe support due to a bug in the native WebView. See https://app.asana.com/0/1203822806345703/1207304124810216/f for details.
Steps to test
TBD. I'll need some help from @CDRussell and/or @GioSensation getting this in an Android build.