-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcs: ignore .helix directory #565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .helix directory is used for directory-specific settings[^1]. Don't track it in git, so I don't accidentally overwrite someone else's settings. No one else at DDG seesm to use helix, but probably easiest to get ahead of it. [^1]: https://docs.helix-editor.com/configuration.html
GioSensation
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
This was referenced Jun 20, 2024
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Jun 21, 2024
Task/Issue URL: https://app.asana.com/0/1207623126907992/1207623126907992 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.0.0 ## Description Updates Autofill to version [12.0.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.0.0). ### Autofill 12.0.0 release notes * Major version bump to 12.0.0 caused by #396, which impacts only Android. * This release also translates the autofill experience to the following language codes: * bg * cs * da * de * el * en * es * et * fi * fr * hr * hu * it * lt * lv * nb * nl * pl * pt * ro * ru * sk * sl * sv * tr ## What's Changed * Ema/more minor fixes by @GioSensation in duckduckgo/duckduckgo-autofill#556 * l10n: extract remaining strings to prepare for localization by @sjbarag in duckduckgo/duckduckgo-autofill#558 * l10n: pull translated strings into separate JSON files by @sjbarag in duckduckgo/duckduckgo-autofill#559 * Update password-related json files (2024-05-13) by @daxmobile in duckduckgo/duckduckgo-autofill#561 * Update password-related json files (2024-05-19) by @daxmobile in duckduckgo/duckduckgo-autofill#569 * vcs: ignore .helix directory by @sjbarag in duckduckgo/duckduckgo-autofill#565 * l10n: remove placeholder from 'Manage ${ITEM}…' string by @sjbarag in duckduckgo/duckduckgo-autofill#560 * real-world: remove expected failure from clientssp.fnfis.com test by @sjbarag in duckduckgo/duckduckgo-autofill#563 * real-world: remove expected failure for agile.appian.com by @sjbarag in duckduckgo/duckduckgo-autofill#567 * autofill: left-align HTML autofill buttons by @sjbarag in duckduckgo/duckduckgo-autofill#571 * l10n: add translated messages by @sjbarag in duckduckgo/duckduckgo-autofill#572 * passwords: require a digit in passwords generated from default rules by @sjbarag in duckduckgo/duckduckgo-autofill#562 * classifiers: fix another batch of test page expected username failures by @sjbarag in duckduckgo/duckduckgo-autofill#573 * Update password-related json files (2024-05-30) by @daxmobile in duckduckgo/duckduckgo-autofill#577 * Update password-related json files (2024-05-31) by @daxmobile in duckduckgo/duckduckgo-autofill#578 * l10n: update translations based on ship review feedback by @sjbarag in duckduckgo/duckduckgo-autofill#581 * android: Revert "Android: enable iframe support (#536)" by @sjbarag in duckduckgo/duckduckgo-autofill#582 ## New Contributors * @sjbarag made their first contribution in duckduckgo/duckduckgo-autofill#558 **Full Changelog**: duckduckgo/duckduckgo-autofill@11.0.2...12.0.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: sjbarag <665775+sjbarag@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Asana:
Description
The .helix directory is used for directory-specific settings1. Don't track it in git, so I don't accidentally overwrite someone else's settings. No one else at DDG seems to use helix, but probably easiest to get ahead of it.
Steps to test
n/a, just a dev quality-of-life improvement
Footnotes
https://docs.helix-editor.com/configuration.html ↩