Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

l10n: update translations based on ship review feedback #581

Merged
merged 1 commit into from
Jun 19, 2024
Merged

l10n: update translations based on ship review feedback #581

merged 1 commit into from
Jun 19, 2024

Conversation

sjbarag
Copy link
Contributor

@sjbarag sjbarag commented Jun 19, 2024

Reviewer: @shakyShane
Asana: https://app.asana.com/0/1142021229838617/1207603156342763/f

Description

After downloading all languages (with language as folders), use this poorly-optimized script to merge those files back in place:

# Make a temporary directory
TMPDIR=$(mktemp -d -p ./)
pushd $TMPDIR

# Extract files
unzip /path/to/autofill.json.zip

# Remove region from language directories
for dir in $(find . -depth 1 -type d -name '*-*'); do
    mv $dir $(echo $dir | cut -c1-4)
done

# Move JSON files back into their language directories
find . \
    -type d
    -depth 1
    -exec mv {}/autofill.json ../src/locales/{}/autofill.json \;

# Clean up
popd
rm -rf $TMPDIR

Steps to test

Use builds attached to https://app.asana.com/0/1142021229838617/1207545752107250/f

@sjbarag sjbarag requested a review from shakyShane June 19, 2024 16:16
@sjbarag
l10n: update translations based on ship review feedback
43ea94c 
After downloading all languages (with language as folders), use this
poorly-optimized script to merge those files back in place:

    # Make a temporary directory
    TMPDIR=$(mktemp -d -p ./)
    pushd $TMPDIR

    # Extract files
    unzip /path/to/autofill.json.zip

    # Remove region from language directories
    for dir in $(find . -depth 1 -type d -name '*-*'); do
        mv $dir $(echo $dir | cut -c1-4)
    done

    # Move JSON files back into their language directories
    find . \
        -type d
        -depth 1
        -exec mv {}/autofill.json ../src/locales/{}/autofill.json \;

    # Clean up
    popd
    rm -rf $TMPDIR
@sjbarag sjbarag merged commit 5e15154 into main Jun 19, 2024
1 check passed
@sjbarag sjbarag deleted the sbarag/ship-review-l10n branch June 19, 2024 21:13
This was referenced Jun 20, 2024
Closed
Merged
Closed
Closed
Closed
CDRussell pushed a commit to duckduckgo/Android that referenced this pull request Jun 21, 2024
@daxmobile @sjbarag
Update autofill to 12.0.0 (#4673)
8b4808f 
Task/Issue URL:
https://app.asana.com/0/1207623126907992/1207623126907992
Autofill Release:
https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.0.0


## Description
Updates Autofill to version
[12.0.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/12.0.0).

### Autofill 12.0.0 release notes
* Major version bump to 12.0.0 caused by #396, which impacts only
Android.
* This release also translates the autofill experience to the following
language codes:
    * bg
    * cs
    * da
    * de
    * el
    * en
    * es
    * et
    * fi
    * fr
    * hr
    * hu
    * it
    * lt
    * lv
    * nb
    * nl
    * pl
    * pt
    * ro
    * ru
    * sk
    * sl
    * sv
    * tr


## What's Changed
* Ema/more minor fixes by @GioSensation in
duckduckgo/duckduckgo-autofill#556
* l10n: extract remaining strings to prepare for localization by
@sjbarag in duckduckgo/duckduckgo-autofill#558
* l10n: pull translated strings into separate JSON files by @sjbarag in
duckduckgo/duckduckgo-autofill#559
* Update password-related json files (2024-05-13) by @daxmobile in
duckduckgo/duckduckgo-autofill#561
* Update password-related json files (2024-05-19) by @daxmobile in
duckduckgo/duckduckgo-autofill#569
* vcs: ignore .helix directory by @sjbarag in
duckduckgo/duckduckgo-autofill#565
* l10n: remove placeholder from 'Manage ${ITEM}…' string by @sjbarag in
duckduckgo/duckduckgo-autofill#560
* real-world: remove expected failure from clientssp.fnfis.com test by
@sjbarag in duckduckgo/duckduckgo-autofill#563
* real-world: remove expected failure for agile.appian.com by @sjbarag
in duckduckgo/duckduckgo-autofill#567
* autofill: left-align HTML autofill buttons by @sjbarag in
duckduckgo/duckduckgo-autofill#571
* l10n: add translated messages by @sjbarag in
duckduckgo/duckduckgo-autofill#572
* passwords: require a digit in passwords generated from default rules
by @sjbarag in
duckduckgo/duckduckgo-autofill#562
* classifiers: fix another batch of test page expected username failures
by @sjbarag in
duckduckgo/duckduckgo-autofill#573
* Update password-related json files (2024-05-30) by @daxmobile in
duckduckgo/duckduckgo-autofill#577
* Update password-related json files (2024-05-31) by @daxmobile in
duckduckgo/duckduckgo-autofill#578
* l10n: update translations based on ship review feedback by @sjbarag in
duckduckgo/duckduckgo-autofill#581
* android: Revert "Android: enable iframe support (#536)" by @sjbarag in
duckduckgo/duckduckgo-autofill#582

## New Contributors
* @sjbarag made their first contribution in
duckduckgo/duckduckgo-autofill#558

**Full Changelog**:
duckduckgo/duckduckgo-autofill@11.0.2...12.0.0

## Steps to test
This release has been tested during autofill development. For smoke test
steps see [this
task](https://app.asana.com/0/1198964220583541/1200583647142330/f).

Co-authored-by: sjbarag <665775+sjbarag@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane shakyShane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjbarag @shakyShane