Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy Pro onboarding dialog copy test #5222

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Privacy Pro onboarding dialog copy test #5222

wants to merge 10 commits into from

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Oct 31, 2024 •
edited by marcosholgado
Loading

Task/Issue URL: https://app.asana.com/0/0/1208628082622869/f

Description

  • Copy test in Privacy Pro onboarding dialog.
  • Different cohorts set in testPrivacyProOnboardingCopyNov24 sub-feature in remote config
    • control
    • protection
    • pir
    • vpn

Steps to test this PR

Pre steps

control Cohort

  • Set control cohort weight to 1 and the rest to 0 in remote config
  • Remove 'DuckDuckGo' folder from Downloads directory
  • Fresh install
  • Tap on a site suggestion
  • Dismiss SERP onboarding dialog
  • Tap on a site suggestion
  • Dismiss Trackers dialog
  • Tap fire button and Clear Data
  • End dialog appears -> Tap on 'High Five!' button
  • Check privacy onboarding has control copy (Asana task with copy)

protection Cohort

  • Set protection cohort weight to 1 and the rest to 0 in remote config
  • Remove 'DuckDuckGo' folder from Downloads directory
  • Fresh install
  • Tap on a site suggestion
  • Dismiss SERP onboarding dialog
  • Tap on a site suggestion
  • Dismiss Trackers dialog
  • Tap fire button and Clear Data
  • End dialog appears -> Tap on 'High Five!' button
  • Check privacy onboarding has protection copy (Asana task with copy)

pir Cohort

  • Set pir cohort weight to 1 and the rest to 0 in remote config
  • Remove 'DuckDuckGo' folder from Downloads directory
  • Fresh install
  • Tap on a site suggestion
  • Dismiss SERP onboarding dialog
  • Tap on a site suggestion
  • Dismiss Trackers dialog
  • Tap fire button and Clear Data
  • End dialog appears -> Tap on 'High Five!' button
  • Check privacy onboarding has pir copy (Asana task with copy)

vpn Cohort

  • Set vpn cohort weight to 1 and the rest to 0 in remote config
  • Remove 'DuckDuckGo' folder from Downloads directory
  • Fresh install
  • Tap on a site suggestion
  • Dismiss SERP onboarding dialog
  • Tap on a site suggestion
  • Dismiss Trackers dialog
  • Tap fire button and Clear Data
  • End dialog appears -> Tap on 'High Five!' button
  • Check privacy onboarding has vpn copy (Asana task with copy)

Returning users

  • Set all cohort weight to 1 in remote config
  • Fresh install
  • Tap on a site suggestion
  • Dismiss SERP onboarding dialog
  • Tap on a site suggestion
  • Dismiss Trackers dialog
  • Tap fire button and Clear Data
  • End dialog appears -> Tap on 'High Five!' button
  • Check privacy onboarding has control copy (Asana task with copy)

Experiment pixels

  • Set vpn cohort weight to 1 and the rest to 0 in remote config
  • Remove 'DuckDuckGo' folder from Downloads directory
  • Fresh install
  • Proceed through onboarding until you reach the Privacy Pro dialog
  • dialogShown
  • Check Privacy Pro dialog is shown
  • Check experiment_metrics_testPrivacyProOnboardingCopyNov24_vpn with params: {metric=dialogShown...} pixel is fired
  • secondaryButtonSelected
  • Tap on Skip button
  • Check experiment_metrics_testPrivacyProOnboardingCopyNov24_vpn with params: {metric=secondaryButtonSelected...} pixel is fired
  • primaryButtonSelected
  • Clear storage
  • Remove 'DuckDuckGo' folder from Downloads directory
  • Open app
  • Proceed through onboarding until you reach the Privacy Pro dialog
  • Tap on Learn More button
  • Check experiment_metrics_testPrivacyProOnboardingCopyNov24_vpn with params: {metric=primaryButtonSelected...} pixel is fired

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@nalcalag
Copy link
Contributor Author

nalcalag commented Oct 31, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag force-pushed the feature/noelia/release_privacy_pro_onbaording_dialog branch 2 times, most recently from 607fbe0 to fcca964 Compare November 9, 2024 00:41
@nalcalag nalcalag force-pushed the feature/noelia/release_privacy_pro_onbaording_dialog branch 2 times, most recently from 39c1a5e to e57f7f9 Compare November 18, 2024 14:21
@nalcalag nalcalag marked this pull request as ready for review November 18, 2024 14:59
@nalcalag nalcalag changed the title Onboarding: Release privacy pro onboarding dialog to all users Privacy Pro onboarding dialog copy test Nov 18, 2024
@nalcalag nalcalag force-pushed the feature/noelia/release_privacy_pro_onbaording_dialog branch from e57f7f9 to 4687e7c Compare November 19, 2024 12:45
marcosholgado
marcosholgado reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is fully working as you expect so gonna comment rather than approve just in case. All the normal cases are fine and work well, the ru does not, the PPro dialog is never shown but the test case says it should be shown.

...com/duckduckgo/app/onboarding/ui/page/extendedonboarding/ExtendedOnboardingFeatureToggles.kt Show resolved Hide resolved
app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt Outdated Show resolved Hide resolved
@nalcalag nalcalag force-pushed the feature/noelia/release_privacy_pro_onbaording_dialog branch from 4687e7c to 1804e69 Compare November 20, 2024 20:58
@nalcalag nalcalag force-pushed the feature/noelia/release_privacy_pro_onbaording_dialog branch from 1804e69 to 065d7c3 Compare November 20, 2024 21:29
marcosholgado
marcosholgado approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosholgado marcosholgado marcosholgado approved these changes

Assignees

@marcosholgado marcosholgado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalcalag @marcosholgado