Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift syntax to Swift 5.7 #280

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Mar 28, 2023

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1203301625297703/1204272370666910/f
iOS PR: N/A
macOS PR: N/A
What kind of version bump will this require?: None

Description:
This change updates Package.swift to modern syntax and switches to Package.resolved version 2.

Steps to test this PR:

  1. Verify that the lib and tests compile.

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ayoy.

@samsymons samsymons assigned ayoy and unassigned samsymons Mar 28, 2023
@ayoy ayoy merged commit 1e55bf9 into main Mar 29, 2023
@ayoy ayoy deleted the dominik/update-package-swift-api branch March 29, 2023 07:21
samsymons added a commit that referenced this pull request Apr 4, 2023
* main:
  sync conect (#281)
  Fix message registration on script reloading (#302)
  Remove codeowner (#301)
  Feature flagging with autofill subfeatures (#270)
  Update codeowner (#297)
  Autofill change to sorting algorithm for displaying logins (#243)
  Update autofill to 6.4.3 (#279)
  move AppHTTPSUpgradeStore to BSK (#267)
  Update Package.swift syntax to Swift 5.7 (#280)
  Use JSON sync code format (#271)
  Update autofill to 6.4.1 (#273)
  Make FeatureName a struct so it can be extended from client code (#276)
  add count of all bookmarks in domain to view model (#272)
samsymons added a commit that referenced this pull request Apr 4, 2023
# By Alexey Martemyanov (2) and others
# Via Alexey Martemyanov (1) and GitHub (1)
* main:
  sync conect (#281)
  Fix message registration on script reloading (#302)
  Remove codeowner (#301)
  Feature flagging with autofill subfeatures (#270)
  Update codeowner (#297)
  Autofill change to sorting algorithm for displaying logins (#243)
  Update autofill to 6.4.3 (#279)
  move AppHTTPSUpgradeStore to BSK (#267)
  Update Package.swift syntax to Swift 5.7 (#280)
  Use JSON sync code format (#271)
  Update autofill to 6.4.1 (#273)

# Conflicts:
#	Package.resolved
#	Package.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants