add count of all bookmarks in domain to view model #272
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
13 tasks
brindy
requested review from
bwaresiak,
mallexxx,
THISISDINOSAUR,
tomasstrba and
samsymons
as code owners
samsymons
added a commit
that referenced
this pull request
Apr 4, 2023
* main: sync conect (#281) Fix message registration on script reloading (#302) Remove codeowner (#301) Feature flagging with autofill subfeatures (#270) Update codeowner (#297) Autofill change to sorting algorithm for displaying logins (#243) Update autofill to 6.4.3 (#279) move AppHTTPSUpgradeStore to BSK (#267) Update Package.swift syntax to Swift 5.7 (#280) Use JSON sync code format (#271) Update autofill to 6.4.1 (#273) Make FeatureName a struct so it can be extended from client code (#276) add count of all bookmarks in domain to view model (#272)
samsymons
added a commit
that referenced
this pull request
Apr 4, 2023
# By Alexey Martemyanov (8) and others # Via GitHub * main: Make FeatureName a struct so it can be extended from client code (#276) add count of all bookmarks in domain to view model (#272) Configuration updates optimizations (#269) Roll-back InteractiveUserScript (#268) Update C-S-S to 4.4.4 (#260) Add invalid payload pixel handler (#264) Fix Error pixel misfiring on valid scenario (#261) add didCancelNavigationAction (#262) Opt-outable private API usage (#254) HTTPS upgrade threading (#256) DDGSync module (#253) fix delayed new window with empty url creation handling (#255) remove major tracker network (#251) Enable username&password passed in URL (#245) fix assertion for popup about:blank navigations without WKNavigation (#247) fix about: scheme fragments dropping (#246) Unify Configuration Management (#241) # Conflicts: # Package.resolved # Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/414235014887631/1204217694278073/f
iOS PR: duckduckgo/iOS#1559
macOS PR: duckduckgo/macos-browser#1048
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL:
CC:
Description:
Steps to test this PR:
1/ see duckduckgo/iOS#1559
2/ smoke test macOS bookmarks management, should be no regression
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template