Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add invalid payload pixel handler #264

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Add invalid payload pixel handler #264

merged 1 commit into from
Mar 17, 2023

Conversation

jaceklyp
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1204156637909205/f
iOS PR: duckduckgo/iOS#1544
macOS PR: duckduckgo/macos-browser#1039
What kind of version bump will this require?: Patch

Description:
Add invalid payload pixel whenever we receive unparsable privacy config / tds.

Steps to test this PR:

  1. Edit the code inside ConfigurationValidator:validate(_:for:) method and override the argument data with e.g. "Hello World".data(using: .utf8)
  2. Run the app for the first time and make sure the pixel is being fired (there is an actual call to the Pixel.fire method)
Internal references:

Software Engineering Expectations
Technical Design Template

bwaresiak
bwaresiak approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaceklyp jaceklyp merged commit 489387e into main Mar 17, 2023
@jaceklyp jaceklyp deleted the jacek/invalid-payload-pixel branch March 17, 2023 10:48
samsymons added a commit that referenced this pull request Apr 4, 2023
@samsymons
Merge branch 'main' into sam/swiftlint-plugin
f98fa7c 
# By Alexey Martemyanov (8) and others
# Via GitHub
* main:
  Make FeatureName a struct so it can be extended from client code (#276)
  add count of all bookmarks in domain to view model (#272)
  Configuration updates optimizations (#269)
  Roll-back InteractiveUserScript (#268)
  Update C-S-S to 4.4.4 (#260)
  Add invalid payload pixel handler (#264)
  Fix Error pixel misfiring on valid scenario (#261)
  add didCancelNavigationAction (#262)
  Opt-outable private API usage (#254)
  HTTPS upgrade threading (#256)
  DDGSync module (#253)
  fix delayed new window with empty url creation handling (#255)
  remove major tracker network (#251)
  Enable username&password passed in URL (#245)
  fix assertion for popup about:blank navigations without WKNavigation (#247)
  fix about: scheme fragments dropping (#246)
  Unify Configuration Management (#241)

# Conflicts:
#	Package.resolved
#	Package.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

@brindy brindy Awaiting requested review from brindy

@mallexxx mallexxx Awaiting requested review from mallexxx

@THISISDINOSAUR THISISDINOSAUR Awaiting requested review from THISISDINOSAUR

@tomasstrba tomasstrba Awaiting requested review from tomasstrba

@samsymons samsymons Awaiting requested review from samsymons

Assignees

@bwaresiak bwaresiak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaceklyp @bwaresiak