Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error pixel misfiring on valid scenario #261

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

bwaresiak
Copy link
Collaborator

@bwaresiak bwaresiak commented Mar 15, 2023

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1200194497630846/1203982975878955/f
iOS PR: duckduckgo/iOS#1542
macOS PR: duckduckgo/macos-browser#1034
What kind of version bump will this require?: Patch

Description:

Fix pixel misfiring on correct flow - see platform PRs for details.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samsymons samsymons assigned bwaresiak and unassigned samsymons Mar 17, 2023
@bwaresiak bwaresiak merged commit 178f4a2 into main Mar 17, 2023
@bwaresiak bwaresiak deleted the bartek/fix-attribution-pixel branch March 17, 2023 08:38
samsymons added a commit that referenced this pull request Apr 4, 2023
# By Alexey Martemyanov (8) and others
# Via GitHub
* main:
  Make FeatureName a struct so it can be extended from client code (#276)
  add count of all bookmarks in domain to view model (#272)
  Configuration updates optimizations (#269)
  Roll-back InteractiveUserScript (#268)
  Update C-S-S to 4.4.4 (#260)
  Add invalid payload pixel handler (#264)
  Fix Error pixel misfiring on valid scenario (#261)
  add didCancelNavigationAction (#262)
  Opt-outable private API usage (#254)
  HTTPS upgrade threading (#256)
  DDGSync module (#253)
  fix delayed new window with empty url creation handling (#255)
  remove major tracker network (#251)
  Enable username&password passed in URL (#245)
  fix assertion for popup about:blank navigations without WKNavigation (#247)
  fix about: scheme fragments dropping (#246)
  Unify Configuration Management (#241)

# Conflicts:
#	Package.resolved
#	Package.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants