Enable username&password passed in URL #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallexxx
requested review from
brindy,
bwaresiak,
THISISDINOSAUR,
tomasstrba and
samsymons
as code owners
This was referenced Mar 2, 2023
brindy
requested changes
Mar 3, 2023
There was a problem hiding this comment.
Unsure what the mailto thing is about, but if that's deliberate this code looks OK and I've seen it working on iOS (under some conditions).
However, the tests appear to be failing. If these are flakey tests, can you comment them out / remove them and create tasks for the owners, please?
| @@ -91,28 +91,54 @@ extension URL { | |||
| public static let blob = NavigationalScheme(rawValue: "blob") | |||
| public static let about = NavigationalScheme(rawValue: "about") | |||
|
|
|||
| public static let mailto = NavigationalScheme(rawValue: "mailto") | |||
There was a problem hiding this comment.
mailto uses the same user@domain.com URL structure which was returning wrong URL for punycoded addresses, this path of URLs with username/password is handled separately from the "normal" URLs
|
the flaky unit tests are fixed in #240 |
brindy
approved these changes
Mar 7, 2023
mallexxx
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Mar 9, 2023
Task/Issue URL: https://app.asana.com/0/414235014887631/1204080079383830/f Tech Design URL: https://app.asana.com/0/481882893211075/1204065038916791/f Security Triage URL: https://app.asana.com/0/1199892415909552/1204067721102886/f BSK PR: duckduckgo/BrowserServicesKit#245 iOS PR: duckduckgo/iOS#1521 CC: @brindy **Description**: - Adds support to pass basic auth username/password in URL **Steps to test this PR**: 1. Validate login/password passed in URL is used for basic authentication and is saved per session 2. Validate login/password passed in URL is not displayed in the UI or saved in browsing history 3. Validate when clicking links containing username/password (user:pass@domain.com), the credentials aren‘t displayed in UI but are used during basic auth 4. Validate if invalid credentials are provided then auth dialog is displayed <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) **When ready for review, remember to post the PR in MM**
ayoy
pushed a commit
to duckduckgo/macos-browser
that referenced
this pull request
Mar 10, 2023
Task/Issue URL: https://app.asana.com/0/414235014887631/1204080079383830/f Tech Design URL: https://app.asana.com/0/481882893211075/1204065038916791/f Security Triage URL: https://app.asana.com/0/1199892415909552/1204067721102886/f BSK PR: duckduckgo/BrowserServicesKit#245 iOS PR: duckduckgo/iOS#1521 CC: @brindy **Description**: - Adds support to pass basic auth username/password in URL **Steps to test this PR**: 1. Validate login/password passed in URL is used for basic authentication and is saved per session 2. Validate login/password passed in URL is not displayed in the UI or saved in browsing history 3. Validate when clicking links containing username/password (user:pass@domain.com), the credentials aren‘t displayed in UI but are used during basic auth 4. Validate if invalid credentials are provided then auth dialog is displayed <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) **When ready for review, remember to post the PR in MM**
samsymons
added a commit
that referenced
this pull request
Apr 4, 2023
# By Alexey Martemyanov (8) and others # Via GitHub * main: Make FeatureName a struct so it can be extended from client code (#276) add count of all bookmarks in domain to view model (#272) Configuration updates optimizations (#269) Roll-back InteractiveUserScript (#268) Update C-S-S to 4.4.4 (#260) Add invalid payload pixel handler (#264) Fix Error pixel misfiring on valid scenario (#261) add didCancelNavigationAction (#262) Opt-outable private API usage (#254) HTTPS upgrade threading (#256) DDGSync module (#253) fix delayed new window with empty url creation handling (#255) remove major tracker network (#251) Enable username&password passed in URL (#245) fix assertion for popup about:blank navigations without WKNavigation (#247) fix about: scheme fragments dropping (#246) Unify Configuration Management (#241) # Conflicts: # Package.resolved # Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/414235014887631/1204080079383830/f
Tech Design URL: https://app.asana.com/0/481882893211075/1204065038916791/f
Security Triage URL: https://app.asana.com/0/1199892415909552/1204067721102886/f
iOS PR: duckduckgo/iOS#1521
macOS PR: duckduckgo/macos-browser#1006
What kind of version bump will this require?: Minor
Description:
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template