Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-windows-browser-download-link-privacy-config #352

Merged

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented May 12, 2023

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1204186595873227/1204569665601043/f
iOS PR: duckduckgo/iOS#1719
macOS PR: duckduckgo/macos-browser#1198
What kind of version bump will this require?: Major/Minor/Patch

Optional:

Tech Design URL:
CC:

Description: It adds a new privacy configuration that regulates whether on iOS the Windows Browser download link should be shown in the waitlist page

Steps to test this PR:

  1. Check that iOS and macOS app build and run correctly

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio self-assigned this May 12, 2023
@SabrinaTardio SabrinaTardio requested a review from ayoy May 12, 2023 17:04
@SabrinaTardio SabrinaTardio marked this pull request as ready for review May 12, 2023 17:04
@ayoy ayoy assigned ayoy and unassigned SabrinaTardio May 15, 2023
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayoy ayoy assigned SabrinaTardio and unassigned ayoy May 16, 2023
@SabrinaTardio SabrinaTardio merged commit d124727 into main May 16, 2023
@SabrinaTardio SabrinaTardio deleted the sabrina/add-windows-browser-download-link-privacy-config branch May 16, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants