Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-windows-browser-download-link-privacy-config #1198

Merged
merged 3 commits into from
May 16, 2023

Conversation

SabrinaTardio
Copy link
Collaborator

@SabrinaTardio SabrinaTardio commented May 12, 2023

Task/Issue URL: https://app.asana.com/0/1204186595873227/1204569665601043/f

Description: It adds a new privacy configuration to BSK that regulates whether on iOS the Windows Browser download link should be shown in the waitlist page. This is the BSK bump

Steps to test this PR:

  1. Check that the app builds and runs correctly

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@SabrinaTardio SabrinaTardio merged commit 6b629df into develop May 16, 2023
@SabrinaTardio SabrinaTardio deleted the sabrina/update-bsk-dependency branch May 16, 2023 13:09
samsymons added a commit that referenced this pull request May 23, 2023
* upstream_develop:
  sync device connected names (#1205)
  Autofill/subdomain matching (#1122)
  add-windows-browser-download-link-privacy-config (#1198)
  Update metadata
  Fix creating DMG from release workflow (#1200)
  Unit tests to cover sensitive areas of Burner Window (#1169)
  [Hackdays] Share via QR Code (#1177)
  Fix sync connect flow  (#1195)
  Update to BSK adding new remote message image (#1194)
  Set version to 1.39.0
  Update embedded files
  Update old Dax asset (#1193)
  WebKit find in page (#1188)
  modify manage bookmarks button (#1175)
  sync update device model / poll for devices (#1191)
samsymons added a commit that referenced this pull request May 27, 2023
* release/1.42.0: (26 commits)
  Bump version to 1.42.0 (28)
  Update embedded files
  Network Protection (#1211)
  Update BSK with autofill 7.1.0 (#1225)
  Autofill password generation support for iOS (#1212)
  Sync Engine with support for syncing bookmarks (#1203)
  Bump BSK for messaging updates (#1213)
  add newTab pixel, fire pixels only for new users first time (#1219)
  Update tds endpoint (#1218)
  prevent devices from being fetch when sync not visible (#1214)
  License and contributor guidelines for open-sourcing (#1189)
  Add a unique Bitwarden decryption failure pixel (#1197)
  Bump version to 1.41.0 (27)
  Update embedded files
  Check that the source and target frame security origins are equal (#1207)
  Add activation points pixels (#1206)
  Add Login export links to settings and Autofill 3 dot menu (#1183)
  sync device connected names (#1205)
  Autofill/subdomain matching (#1122)
  add-windows-browser-download-link-privacy-config (#1198)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants