This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Add activation points pixels #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
approved these changes
May 19, 2023
Collaborator
ayoy
left a comment
ayoy
left a comment
There was a problem hiding this comment.
LGTM! I’ve tested everything and everything worked on my end. Just one minor comment and it’s good to go 👏
samsymons
added a commit
that referenced
this pull request
May 23, 2023
# By Sabrina Tardio (2) and Sam Symons (1) # Via GitHub * upstream_develop: Check that the source and target frame security origins are equal (#1207) Add activation points pixels (#1206) Add Login export links to settings and Autofill 3 dot menu (#1183) # Conflicts: # DuckDuckGo/Menus/MainMenuActions.swift # DuckDuckGo/Statistics/PixelEvent.swift # DuckDuckGo/Statistics/PixelParameters.swift # UnitTests/Menus/Mocks/CapturingOptionsButtonMenuDelegate.swift
samsymons
added a commit
that referenced
this pull request
May 27, 2023
* release/1.42.0: (26 commits) Bump version to 1.42.0 (28) Update embedded files Network Protection (#1211) Update BSK with autofill 7.1.0 (#1225) Autofill password generation support for iOS (#1212) Sync Engine with support for syncing bookmarks (#1203) Bump BSK for messaging updates (#1213) add newTab pixel, fire pixels only for new users first time (#1219) Update tds endpoint (#1218) prevent devices from being fetch when sync not visible (#1214) License and contributor guidelines for open-sourcing (#1189) Add a unique Bitwarden decryption failure pixel (#1197) Bump version to 1.41.0 (27) Update embedded files Check that the source and target frame security origins are equal (#1207) Add activation points pixels (#1206) Add Login export links to settings and Autofill 3 dot menu (#1183) sync device connected names (#1205) Autofill/subdomain matching (#1122) add-windows-browser-download-link-privacy-config (#1198) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1204614030645089/f
Description: Add Temporary initial pixels for 5 activation points: Enable email Protection, Watch in Duck Player, Enable cookie pop up management, Make default browser, Import bookmarks or passwords.
Steps to test this PR:
<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the
DO NOT MERGElabel (particularly if it's a draft)If it's pending Product Review/PFR, please add the
Pending Product Reviewlabel.If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation