Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump BSK for messaging updates #1213

Merged
merged 2 commits into from
May 25, 2023
Merged

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented May 23, 2023

Task/Issue URL: https://app.asana.com/0/0/1204657577764249/f
Tech Design URL:
CC:

Description:

Update macOS to use latest BSK https://app.asana.com/0/0/1204544767438474/f

Those changes to BSK are all additions - there are no functional changes to macOS in this PR, it's just keeping it up to date to allow ClickToLoad, DataBrokerProtection and DuckPlayer to use them.

BSK PR: duckduckgo/BrowserServicesKit#299

Steps to test this PR:

  1. No functional changes should be present - so just verifying everything still works as it did before

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@shakyShane
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@shakyShane shakyShane requested a review from ayoy May 23, 2023 11:39
@shakyShane
Copy link
Collaborator Author

@ayoy - any chance you could take this one:

The context is that the other PR (to remove Duck Player FE assets) depends on this. But also, Click to Load and DataBrokerProtection will use it too.

It's 100% backwards compatible.

Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@shakyShane shakyShane merged commit 9554069 into develop May 25, 2023
@shakyShane shakyShane deleted the shane/bsk-messaging-update branch May 25, 2023 16:01
samsymons added a commit that referenced this pull request May 26, 2023
* upstream_develop:
  Bump BSK for messaging updates (#1213)
samsymons added a commit that referenced this pull request May 27, 2023
* release/1.42.0: (26 commits)
  Bump version to 1.42.0 (28)
  Update embedded files
  Network Protection (#1211)
  Update BSK with autofill 7.1.0 (#1225)
  Autofill password generation support for iOS (#1212)
  Sync Engine with support for syncing bookmarks (#1203)
  Bump BSK for messaging updates (#1213)
  add newTab pixel, fire pixels only for new users first time (#1219)
  Update tds endpoint (#1218)
  prevent devices from being fetch when sync not visible (#1214)
  License and contributor guidelines for open-sourcing (#1189)
  Add a unique Bitwarden decryption failure pixel (#1197)
  Bump version to 1.41.0 (27)
  Update embedded files
  Check that the source and target frame security origins are equal (#1207)
  Add activation points pixels (#1206)
  Add Login export links to settings and Autofill 3 dot menu (#1183)
  sync device connected names (#1205)
  Autofill/subdomain matching (#1122)
  add-windows-browser-download-link-privacy-config (#1198)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants