Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@amddg44
Copy link
Contributor

@amddg44 amddg44 commented May 23, 2023

Task/Issue URL: https://app.asana.com/0/72649045549333/1204452429715454/f
Tech Design URL:
CC:

Description:
BSK updates to enable support for autofill password generation on iOS

Steps to test this PR:
Smoke test to confirm no autofill save behaviour has changed including:

  1. Saving a registration form login with a generated password
  2. Selecting a generated password, then entering a username and saving the registration form login
  3. Saving a registration form login using a manually entered password
  4. Saving login form credentials

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

amddg44 added 3 commits May 15, 2023 12:39
…word-generation

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/Autofill/ContentOverlayViewController.swift
#	DuckDuckGo/Tab/TabExtensions/AutofillTabExtension.swift
amddg44 added a commit to duckduckgo/BrowserServicesKit that referenced this pull request May 26, 2023
Task/Issue URL: https://app.asana.com/0/72649045549333/1204452429715454/f
iOS PR: duckduckgo/iOS#1736
macOS PR: duckduckgo/macos-browser#1212
What kind of version bump will this require?: Minor

Description:
Update to enable support for autofill password generation on iOS
amddg44 added 3 commits May 26, 2023 16:46
…word-generation

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@amddg44 amddg44 self-assigned this May 26, 2023
@amddg44 amddg44 merged commit 8c64749 into develop May 26, 2023
@amddg44 amddg44 deleted the autofill/anya/password-generation branch May 26, 2023 15:49
samsymons added a commit that referenced this pull request May 26, 2023
* upstream_develop:
  Update BSK with autofill 7.1.0 (#1225)
  Autofill password generation support for iOS (#1212)
samsymons added a commit that referenced this pull request May 27, 2023
* release/1.42.0: (26 commits)
  Bump version to 1.42.0 (28)
  Update embedded files
  Network Protection (#1211)
  Update BSK with autofill 7.1.0 (#1225)
  Autofill password generation support for iOS (#1212)
  Sync Engine with support for syncing bookmarks (#1203)
  Bump BSK for messaging updates (#1213)
  add newTab pixel, fire pixels only for new users first time (#1219)
  Update tds endpoint (#1218)
  prevent devices from being fetch when sync not visible (#1214)
  License and contributor guidelines for open-sourcing (#1189)
  Add a unique Bitwarden decryption failure pixel (#1197)
  Bump version to 1.41.0 (27)
  Update embedded files
  Check that the source and target frame security origins are equal (#1207)
  Add activation points pixels (#1206)
  Add Login export links to settings and Autofill 3 dot menu (#1183)
  sync device connected names (#1205)
  Autofill/subdomain matching (#1122)
  add-windows-browser-download-link-privacy-config (#1198)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants