Autofill password generation support for iOS #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…word-generation # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Autofill/ContentOverlayViewController.swift # DuckDuckGo/Tab/TabExtensions/AutofillTabExtension.swift
6 tasks
afterxleep
approved these changes
May 25, 2023
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 26, 2023
Task/Issue URL: https://app.asana.com/0/72649045549333/1204452429715454/f iOS PR: duckduckgo/iOS#1736 macOS PR: duckduckgo/macos-browser#1212 What kind of version bump will this require?: Minor Description: Update to enable support for autofill password generation on iOS
…word-generation # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
May 27, 2023
* release/1.42.0: (26 commits) Bump version to 1.42.0 (28) Update embedded files Network Protection (#1211) Update BSK with autofill 7.1.0 (#1225) Autofill password generation support for iOS (#1212) Sync Engine with support for syncing bookmarks (#1203) Bump BSK for messaging updates (#1213) add newTab pixel, fire pixels only for new users first time (#1219) Update tds endpoint (#1218) prevent devices from being fetch when sync not visible (#1214) License and contributor guidelines for open-sourcing (#1189) Add a unique Bitwarden decryption failure pixel (#1197) Bump version to 1.41.0 (27) Update embedded files Check that the source and target frame security origins are equal (#1207) Add activation points pixels (#1206) Add Login export links to settings and Autofill 3 dot menu (#1183) sync device connected names (#1205) Autofill/subdomain matching (#1122) add-windows-browser-download-link-privacy-config (#1198) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1204452429715454/f
Tech Design URL:
CC:
Description:
BSK updates to enable support for autofill password generation on iOS
Steps to test this PR:
Smoke test to confirm no autofill save behaviour has changed including:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation