This repository was archived by the owner on Feb 24, 2025. It is now read-only.
[Hackdays] Share via QR Code #1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
approved these changes
May 12, 2023
| } | ||
|
|
||
| var ciImage: CIImage { | ||
| var rect = NSRect(x: 0, y: 0, width: self.size.width * 2, height: self.size.height * 2) |
Collaborator
There was a problem hiding this comment.
Is the * 2 here to handle Retina? Can we try using NSScreen.main?.backingScaleFactor and fall back to 2?
Same applies to CIImage.bitmapRepresentation(using format: NSBitmapImageRep.FileType).
|
|
||
| static let duckDuckGo: QRCodeParameters = { | ||
| let icon: CIImage = { | ||
| let logo = NSImage(named: "Logo")! |
Collaborator
There was a problem hiding this comment.
This is using the old Dax icon. Please replace with the new one.
samsymons
added a commit
that referenced
this pull request
May 23, 2023
* upstream_develop: sync device connected names (#1205) Autofill/subdomain matching (#1122) add-windows-browser-download-link-privacy-config (#1198) Update metadata Fix creating DMG from release workflow (#1200) Unit tests to cover sensitive areas of Burner Window (#1169) [Hackdays] Share via QR Code (#1177) Fix sync connect flow (#1195) Update to BSK adding new remote message image (#1194) Set version to 1.39.0 Update embedded files Update old Dax asset (#1193) WebKit find in page (#1188) modify manage bookmarks button (#1175) sync update device model / poll for devices (#1191)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/42792087274227/1204180319229124/f
Description:
Adds "QR Code" item to Share menu
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM