Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@brindy
Copy link
Contributor

@brindy brindy commented May 10, 2023

Task/Issue URL:

Tech Design URL:
CC:

Description:

Device model updates. Refresh device list and fix it when first turning on sync.

Steps to test this PR:

  1. Ensure you can turn on, turn off sync
  2. Rename the device
  3. Add/remove a second device, it should update the UI after max 10 seconds to show the new device

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

Fails
🚫 Please, don't forget to add a link to the internal task

Generated by 🚫 dangerJS against e3c65bc

Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Refreshing works great 😎

@ayoy ayoy assigned brindy and unassigned ayoy May 10, 2023
@brindy brindy merged commit 8a89014 into develop May 10, 2023
@brindy brindy deleted the brindy/sync-update-device-model branch May 10, 2023 22:09
samsymons added a commit that referenced this pull request May 12, 2023
* release/1.39.0:
  Set version to 1.39.0
  Update embedded files
  Update old Dax asset (#1193)
  WebKit find in page (#1188)
  modify manage bookmarks button (#1175)
  sync update device model / poll for devices (#1191)
  Fix creating DMG images in GitHub Actions (#1185)
  Update Privacy Dashboard info on redirect (#1186)
  Update BSK with autofill 6.5.1 (#1182)
  Only use LazyVStack on home page when on macos 12 or higher (#1181)
  Update PULL_REQUEST_TEMPLATE.md (#1173)
  Sabrina/allow tabs in single tab windows to be moved to other windows (#1174)
  Version 1.38.1
  Version 1.38.0
  Embeded files updated
  Remove the Fire button pixel (#1151)
  remove duck player pixels (#1176)
  Adding a mitigation for youtube-nocookie storing data in localStorage (#1172)
  fix bug  where pasting url into address bar clears its content (#1166)
samsymons added a commit that referenced this pull request May 23, 2023
* upstream_develop:
  sync device connected names (#1205)
  Autofill/subdomain matching (#1122)
  add-windows-browser-download-link-privacy-config (#1198)
  Update metadata
  Fix creating DMG from release workflow (#1200)
  Unit tests to cover sensitive areas of Burner Window (#1169)
  [Hackdays] Share via QR Code (#1177)
  Fix sync connect flow  (#1195)
  Update to BSK adding new remote message image (#1194)
  Set version to 1.39.0
  Update embedded files
  Update old Dax asset (#1193)
  WebKit find in page (#1188)
  modify manage bookmarks button (#1175)
  sync update device model / poll for devices (#1191)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants