This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Remove the Fire button pixel #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
requested review from
a team and
diegoreymendez
and removed request for
a team
diegoreymendez
approved these changes
Apr 28, 2023
mallexxx
pushed a commit
that referenced
this pull request
May 4, 2023
Task/Issue URL: https://app.asana.com/0/1199230911884351/1204449985248662/f Tech Design URL: CC: Description: Remove the Fire button usage pixel.
samsymons
added a commit
that referenced
this pull request
May 12, 2023
* release/1.39.0: Set version to 1.39.0 Update embedded files Update old Dax asset (#1193) WebKit find in page (#1188) modify manage bookmarks button (#1175) sync update device model / poll for devices (#1191) Fix creating DMG images in GitHub Actions (#1185) Update Privacy Dashboard info on redirect (#1186) Update BSK with autofill 6.5.1 (#1182) Only use LazyVStack on home page when on macos 12 or higher (#1181) Update PULL_REQUEST_TEMPLATE.md (#1173) Sabrina/allow tabs in single tab windows to be moved to other windows (#1174) Version 1.38.1 Version 1.38.0 Embeded files updated Remove the Fire button pixel (#1151) remove duck player pixels (#1176) Adding a mitigation for youtube-nocookie storing data in localStorage (#1172) fix bug where pasting url into address bar clears its content (#1166)
samsymons
added a commit
that referenced
this pull request
May 23, 2023
# By Alexey Martemyanov (56) and others # Via Dominik Kapusta (6) and others * upstream_develop: (267 commits) Fix creating DMG images in GitHub Actions (#1185) Update Privacy Dashboard info on redirect (#1186) Update BSK with autofill 6.5.1 (#1182) Only use LazyVStack on home page when on macos 12 or higher (#1181) Version 1.38.2 Update PULL_REQUEST_TEMPLATE.md (#1173) New Dax Icons (#1179) fix Tab Bar disappearing in Fullscreen Split View (#1168) Sabrina/allow tabs in single tab windows to be moved to other windows (#1174) Version 1.38.1 Version 1.38.0 Embeded files updated Fix TabBar scrolling (#1178) Remove the Fire button pixel (#1151) remove duck player pixels (#1176) Adding a mitigation for youtube-nocookie storing data in localStorage (#1172) Version 1.38.1 fix bug where pasting url into address bar clears its content (#1166) Version 1.38.0 Embeded files updated ... # Conflicts: # .github/workflows/danger.yml # .github/workflows/pr.yml # .github/workflows/release.yml # .swiftlint.tests.yml # .swiftlint.yml # .xcode-version # Configuration/AppStoreBuildNumber.xcconfig # Configuration/Configuration.xcconfig # Configuration/Tests/IntegrationTests.xcconfig # Configuration/Tests/UnitTests.xcconfig # Configuration/Version.xcconfig # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo Privacy Browser App Store.xcscheme # DuckDuckGo/API/APIHeaders.swift # DuckDuckGo/API/APIRequest.swift # DuckDuckGo/App Delegate/UpdateController.swift # DuckDuckGo/AppDelegate/AppDelegate.swift # DuckDuckGo/AppDelegate/AppIconChanger.swift # DuckDuckGo/AppDelegate/URLEventHandler.swift # DuckDuckGo/Assets.xcassets/Images/InternalChannelIcon.imageset/Contents.json # DuckDuckGo/Autoconsent/AutoconsentUserScript.swift # DuckDuckGo/Autoconsent/UI/CookieConsentPopoverManager.swift # DuckDuckGo/Autofill/ContentOverlayViewController.swift # DuckDuckGo/Bookmarks/Model/BookmarkList.swift # DuckDuckGo/Bookmarks/Model/BookmarkManager.swift # DuckDuckGo/Bookmarks/Services/BookmarkStore.swift # DuckDuckGo/Bookmarks/View/AddBookmarkModalViewController.swift # DuckDuckGo/Bookmarks/View/BookmarkListViewController.swift # DuckDuckGo/Bookmarks/View/BookmarkManagementDetailViewController.swift # DuckDuckGo/Bookmarks/View/BookmarkManagementSidebarViewController.swift # DuckDuckGo/Bookmarks/ViewModel/BookmarkViewModel.swift # DuckDuckGo/Browser Tab/Extensions/AdClickAttributionTabExtension.swift # DuckDuckGo/Browser Tab/Model/Tab.swift # DuckDuckGo/Browser Tab/ViewModel/WebViewStateObserver.swift # DuckDuckGo/Common/AppVersion.swift # DuckDuckGo/Common/Database/Database.swift # DuckDuckGo/Common/Extensions/FileManagerExtension.swift # DuckDuckGo/Common/Extensions/NSAlertExtension.swift # DuckDuckGo/Common/Extensions/NSApplicationExtension.swift # DuckDuckGo/Common/Extensions/NSColorExtension.swift # DuckDuckGo/Common/Extensions/NSPasteboardExtension.swift # DuckDuckGo/Common/Extensions/NSPasteboardItemExtension.swift # DuckDuckGo/Common/Extensions/WKUserContentControllerExtension.swift # DuckDuckGo/Common/Extensions/WKWebViewExtension.swift # DuckDuckGo/Common/Localizables/UserText.swift # DuckDuckGo/Common/Logging/Logging.swift # DuckDuckGo/Common/Utilities/ErrorWithParameters.swift # DuckDuckGo/Common/Utilities/UserDefaultsWrapper.swift # DuckDuckGo/Common/View/AppKit/NSSavePanelExtension.swift # DuckDuckGo/Configuration/ConfigurationDownloading.swift # DuckDuckGo/Configuration/ConfigurationStore.swift # DuckDuckGo/ContentBlocker/AppPrivacyConfigurationDataProvider.swift # DuckDuckGo/ContentBlocker/AppTrackerDataSetProvider.swift # DuckDuckGo/ContentBlocker/macos-config.json # DuckDuckGo/ContentBlocker/trackerData.json # DuckDuckGo/Data Import/Logins/Firefox/FirefoxBerkeleyDatabaseReader.m # DuckDuckGo/Favicons/Model/FaviconManager.swift # DuckDuckGo/Feedback/View/FeedbackPresenter.swift # DuckDuckGo/File Download/Model/UTType.swift # DuckDuckGo/FileDownload/Extensions/WKWebView+Download.swift # DuckDuckGo/FileDownload/Model/FileDownloadManager.swift # DuckDuckGo/Fire/Model/Fire.swift # DuckDuckGo/HomePage/Model/HomePageFavoritesModel.swift # DuckDuckGo/HomePage/View/FavoritesView.swift # DuckDuckGo/Info.plist # DuckDuckGo/Main/View/MainWindowController.swift # DuckDuckGo/Menus/MainMenu.storyboard # DuckDuckGo/Menus/MainMenu.swift # DuckDuckGo/Menus/MainMenuActions.swift # DuckDuckGo/Menus/SharingMenu.swift # DuckDuckGo/NavigationBar/PinningManager.swift # DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift # DuckDuckGo/NavigationBar/View/AddressBarTextField.swift # DuckDuckGo/NavigationBar/View/MoreOptionsMenu.swift # DuckDuckGo/NavigationBar/View/NavigationBar.storyboard # DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift # DuckDuckGo/PasswordManager/Bitwarden/Model/BWManagement.swift # DuckDuckGo/PasswordManager/Bitwarden/Model/BWManager.swift # DuckDuckGo/PasswordManager/Bitwarden/View/BWNotRespondingAlert.swift # DuckDuckGo/Preferences/Model/AutofillPreferencesModel.swift # DuckDuckGo/Preferences/View/Preferences.swift # DuckDuckGo/Preferences/View/PreferencesAutofillView.swift # DuckDuckGo/Preferences/View/PreferencesViewController.swift # DuckDuckGo/Smarter Encryption/HTTPSBloomFilterSpecification.swift # DuckDuckGo/Smarter Encryption/HTTPSUpgrade.swift # DuckDuckGo/Smarter Encryption/Store/AppHTTPSUpgradeStore.swift # DuckDuckGo/Statistics/ATB/StatisticsLoader.swift # DuckDuckGo/Statistics/PixelEvent.swift # DuckDuckGo/Statistics/PixelParameters.swift # DuckDuckGo/Tab/Model/Tab+Dialogs.swift # DuckDuckGo/Tab/Model/Tab+UIDelegate.swift # DuckDuckGo/Tab/TabExtensions/TabExtensions.swift # DuckDuckGo/Tab/View/BrowserTabViewController.swift # DuckDuckGo/TabBar/View/TabBarViewController.swift # DuckDuckGo/TabBar/View/TabDragAndDropManager.swift # DuckDuckGo/TabBar/ViewModel/TabCollectionViewModel.swift # DuckDuckGo/Youtube Player/PrivatePlayer.swift # DuckDuckGo/YoutubePlayer/YoutubePlayerUserScript.swift # Integration Tests/Autoconsent/AutoconsentBackgroundTests.swift # IntegrationTests/autoconsent-test-page-banner.html # LocalPackages/SwiftUIExtensions/Sources/SwiftUIExtensions/HoverButton.swift # LocalPackages/SwiftUIExtensions/Sources/SwiftUIExtensions/TextButton.swift # Packages/NetworkProtectionUI/Tests/NetworkProtectionUITests/NetworkProtectionUITests.swift # Submodules/privacy-reference-tests # Unit Tests/Browser Tab/Model/TabTests.swift # Unit Tests/Configuration/ConfigurationDownloaderTests.swift # Unit Tests/User Agent/Model/UserAgentTests.swift # Unit Tests/Youtube Player/PrivatePlayerTests.swift # UnitTests/App/WindowManagerStateRestorationTests.swift # UnitTests/Bookmarks/Services/LocalBookmarkStoreTests.swift # UnitTests/Common/Extensions/FutureExtensionTests.swift # UnitTests/Common/FileSystemDSLTests.swift # UnitTests/ContentBlocker/AppPrivacyConfigurationTests.swift # UnitTests/HomePage/RecentlyVisitedSiteModelTests.swift # UnitTests/PrivacyReferenceTests/FireproofingReferenceTests.swift # UnitTests/PrivacyReferenceTests/PrivacyReferenceTestHelper.swift # fastlane/metadata/default/release_notes.txt # scripts/archive.sh # set_version.sh
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1204449985248662/f
Tech Design URL:
CC:
Description:
Remove the Fire button usage pixel.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM