modify manage bookmarks button #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabrinaTardio
requested review from
a team and
brindy
and removed request for
a team
brindy
approved these changes
May 10, 2023
| manageBookmarksButton.imageHugsTitle = true | ||
|
|
||
| // Set up constraints | ||
| let titleWidth = (CGFloat(manageBookmarksButton.title.count - 1) * 7.0 + 9) |
There was a problem hiding this comment.
Rather than hardcoding those magic numbers you could just calculate the width like this:
Suggested change
| let titleWidth = (CGFloat(manageBookmarksButton.title.count - 1) * 7.0 + 9) | |
| let titleWidth = (manageBookmarksButton.title as NSString).size(withAttributes: [.font: manageBookmarksButton.font as Any]).width |
| let buttonWidth = imageSize.width + titleWidth + padding * 3 | ||
| manageBookmarksButton.translatesAutoresizingMaskIntoConstraints = false | ||
| let widthConstraint = NSLayoutConstraint(item: manageBookmarksButton!, attribute: NSLayoutConstraint.Attribute.width, relatedBy: NSLayoutConstraint.Relation.equal, toItem: nil, attribute: NSLayoutConstraint.Attribute.notAnAttribute, multiplier: 1, constant: buttonWidth) | ||
| let heightConstraint = NSLayoutConstraint(item: manageBookmarksButton!, attribute: NSLayoutConstraint.Attribute.height, relatedBy: NSLayoutConstraint.Relation.equal, toItem: nil, attribute: NSLayoutConstraint.Attribute.notAnAttribute, multiplier: 1, constant: 28) |
There was a problem hiding this comment.
The height constraint isn't needed.
There was a problem hiding this comment.
It is needed for the padding on hover. It was set on the storyboard but since we are trying to step away from them I thought moving the constraint in code was a teeeeeeny step towards that
samsymons
added a commit
that referenced
this pull request
May 12, 2023
* release/1.39.0: Set version to 1.39.0 Update embedded files Update old Dax asset (#1193) WebKit find in page (#1188) modify manage bookmarks button (#1175) sync update device model / poll for devices (#1191) Fix creating DMG images in GitHub Actions (#1185) Update Privacy Dashboard info on redirect (#1186) Update BSK with autofill 6.5.1 (#1182) Only use LazyVStack on home page when on macos 12 or higher (#1181) Update PULL_REQUEST_TEMPLATE.md (#1173) Sabrina/allow tabs in single tab windows to be moved to other windows (#1174) Version 1.38.1 Version 1.38.0 Embeded files updated Remove the Fire button pixel (#1151) remove duck player pixels (#1176) Adding a mitigation for youtube-nocookie storing data in localStorage (#1172) fix bug where pasting url into address bar clears its content (#1166)
samsymons
added a commit
that referenced
this pull request
May 23, 2023
* upstream_develop: sync device connected names (#1205) Autofill/subdomain matching (#1122) add-windows-browser-download-link-privacy-config (#1198) Update metadata Fix creating DMG from release workflow (#1200) Unit tests to cover sensitive areas of Burner Window (#1169) [Hackdays] Share via QR Code (#1177) Fix sync connect flow (#1195) Update to BSK adding new remote message image (#1194) Set version to 1.39.0 Update embedded files Update old Dax asset (#1193) WebKit find in page (#1188) modify manage bookmarks button (#1175) sync update device model / poll for devices (#1191)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1204110808978984/f
Description: Modify the button to open the bookmarks management page
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM