Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to BSK adding new remote message image #1194

Merged
merged 2 commits into from
May 12, 2023
Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented May 11, 2023

Task/Issue URL: https://app.asana.com/0/0/1204559401135163/f
Tech Design URL:
CC:

Description:
Support for new image added to remote message framework in BSK

Steps to test this PR:

  1. There should be no impact at all; just launch the app and confirm everything runs as normal

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

amddg44 added a commit to duckduckgo/BrowserServicesKit that referenced this pull request May 12, 2023
Task/Issue URL: https://app.asana.com/0/0/1204559401135163/f
iOS PR: duckduckgo/iOS#1714
macOS PR: duckduckgo/macos-browser#1194
What kind of version bump will this require?: Minor

Description:
Adds support for new MacComputer image
@amddg44 amddg44 merged commit c1eaa24 into develop May 12, 2023
@amddg44 amddg44 deleted the anya/rmf-asset-update branch May 12, 2023 14:19
samsymons added a commit that referenced this pull request May 23, 2023
* upstream_develop:
  sync device connected names (#1205)
  Autofill/subdomain matching (#1122)
  add-windows-browser-download-link-privacy-config (#1198)
  Update metadata
  Fix creating DMG from release workflow (#1200)
  Unit tests to cover sensitive areas of Burner Window (#1169)
  [Hackdays] Share via QR Code (#1177)
  Fix sync connect flow  (#1195)
  Update to BSK adding new remote message image (#1194)
  Set version to 1.39.0
  Update embedded files
  Update old Dax asset (#1193)
  WebKit find in page (#1188)
  modify manage bookmarks button (#1175)
  sync update device model / poll for devices (#1191)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants