Unit tests to cover sensitive areas of Burner Window #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tomasstrba
requested review from
a team and
diegoreymendez
and removed request for
a team
diegoreymendez
approved these changes
Apr 28, 2023
| class HistoryTabExtensionTests: XCTestCase { | ||
|
|
||
| @MainActor | ||
| func testWhenBurnerTab_ThenNoHistoryIsStored() { |
There was a problem hiding this comment.
I don't feel strongly against this, but I just went ahead to check the code and noticed there aren't many instances of this so it made me wonder if it was on purpose.
There was a problem hiding this comment.
Diego, that's a good question. I have also noticed we lack more tests for tab extensions.
DuckDuckGo.xcodeproj/project.pbxproj
Outdated
| kind = exactVersion; | ||
| version = 57.4.2; | ||
| branch = "tom/burner-window-unit-tests"; | ||
| kind = branch; |
There was a problem hiding this comment.
Just a reminder to update this, since sometimes it's easy to forget.
|
@tomasstrba - Just a reminder that this is good to go. |
samsymons
added a commit
that referenced
this pull request
May 23, 2023
* upstream_develop: sync device connected names (#1205) Autofill/subdomain matching (#1122) add-windows-browser-download-link-privacy-config (#1198) Update metadata Fix creating DMG from release workflow (#1200) Unit tests to cover sensitive areas of Burner Window (#1169) [Hackdays] Share via QR Code (#1177) Fix sync connect flow (#1195) Update to BSK adding new remote message image (#1194) Set version to 1.39.0 Update embedded files Update old Dax asset (#1193) WebKit find in page (#1188) modify manage bookmarks button (#1175) sync update device model / poll for devices (#1191)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1204489493401944/f
BSK PR: duckduckgo/BrowserServicesKit#340
Description:
Unit tests to make sure Burner Windows don't store history, downloads and favicons.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM