Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concurrency extension, refactor Connection Tester to use AsyncSeq… #443

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Add concurrency extension, refactor Connection Tester to use AsyncSeq… #443

merged 1 commit into from
Aug 2, 2023

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Aug 2, 2023 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1199230911884351/1205173072817391/f
macOS PR: duckduckgo/macos-browser#1422
What kind of version bump will this require?: Minor

Optional:

Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. Validate Connection Tester is working

@mallexxx mallexxx requested a review from graeme August 2, 2023 12:42
@mallexxx mallexxx mentioned this pull request Aug 2, 2023
Merged
graeme
graeme approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all working as described 👍

@mallexxx mallexxx merged commit 44e12ce into main Aug 2, 2023
4 checks passed
@mallexxx mallexxx deleted the alex/async-extensions branch August 2, 2023 16:03
mallexxx added a commit to duckduckgo/macos-browser that referenced this pull request Aug 2, 2023
@mallexxx
Fix Xcode 15 App Store build and some warnings (#1422)
12deffe 
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205173072817391/f
BSK PR: duckduckgo/BrowserServicesKit#443
afterxleep pushed a commit that referenced this pull request Aug 2, 2023
@mallexxx @afterxleep
Add concurrency extension, refactor Connection Tester to use AsyncSeq…
a5d33aa 
…uence (#443)

Task/Issue URL: https://app.asana.com/0/1199230911884351/1205173072817391/f
macOS PR: duckduckgo/macos-browser#1422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme graeme graeme approved these changes

Assignees

@graeme graeme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @graeme