Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xcode 15 App Store build and some warnings #1422

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix Xcode 15 App Store build and some warnings #1422

merged 2 commits into from
Aug 2, 2023

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Aug 2, 2023

Task/Issue URL: https://app.asana.com/0/1199230911884351/1205173072817391/f
BSK PR: duckduckgo/BrowserServicesKit#443

Description:

  • Fixes App Store target in Xcode 15
  • Fixed some warnings
  • Non-App Store target still fails on linker

Steps to test this PR:

  1. Validate Xcode 15 build works and runs under Xcode 15
  2. Validate Non-Appstore build works under Xcode 14 and Connection Tester works (open Console app, enter Network Protection filter, connect to VPN, wait for connection tester 👍 message)
Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from graeme August 2, 2023 13:01
@mallexxx mallexxx mentioned this pull request Aug 2, 2023
Merged
graeme
graeme approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ran all the test steps and all working as described

mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 2, 2023
@mallexxx
Add concurrency extension, refactor Connection Tester to use AsyncSeq…
44e12ce 
…uence (#443)

Task/Issue URL: https://app.asana.com/0/1199230911884351/1205173072817391/f
macOS PR: duckduckgo/macos-browser#1422
@mallexxx mallexxx merged commit 12deffe into develop Aug 2, 2023
6 of 7 checks passed
@mallexxx mallexxx deleted the alex/fix-xcode15 branch August 2, 2023 16:09
afterxleep pushed a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 2, 2023
@mallexxx @afterxleep
Add concurrency extension, refactor Connection Tester to use AsyncSeq…
a5d33aa 
…uence (#443)

Task/Issue URL: https://app.asana.com/0/1199230911884351/1205173072817391/f
macOS PR: duckduckgo/macos-browser#1422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme graeme graeme approved these changes

Assignees

@graeme graeme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @graeme