feat: duck player v2 #451
Merged
feat: duck player v2 #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
shakyShane
force-pushed
the
shane/duckplayer-v2
branch
2 times, most recently
from
e473366
to
761bb8c
Compare
shakyShane
force-pushed
the
shane/duckplayer-v2
branch
from
761bb8c
to
19f83f8
Compare
samsymons
added a commit
that referenced
this pull request
Aug 16, 2023
# By Sam Symons (3) and others # Via GitHub * main: Moved iOS Extension to BSK (#458) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#431) feat: duck player v2 (#451) Update NetP endpoint (#456) BSK SwiftLint fixes part 2: Disable some test suite warnings (#453) BSK SwiftLint fixes part 1: Autofix many SwiftLint warnings (#452) Add support for syncing Credentials (#425) Update autofill to 8.1.2 (#457) NetP - Create observers to extract from StatusReporter (#445) # Conflicts: # Sources/BookmarksTestsUtils/BookmarkTree.swift # Sources/BrowserServicesKit/Autofill/AutofillUserScript+SecureVault.swift # Sources/BrowserServicesKit/SecureVault/AutofillSecureVault.swift # Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift # Sources/BrowserServicesKit/SecureVault/SecureVaultModels.swift # Sources/BrowserServicesKit/Suggestions/Suggestion.swift # Sources/SyncDataProviders/Bookmarks/BookmarksProvider.swift # Tests/.swiftlint.yml # Tests/BrowserServicesKitTests/SecureVault/MockAutofillDatabaseProvider.swift # Tests/BrowserServicesKitTests/SecureVault/VaultFactoryTests.swift # Tests/NavigationTests/ClosureNavigationResponderTests.swift # Tests/NavigationTests/Helpers/NavigationTestHelpers.swift # Tests/NavigationTests/NavigationAuthChallengeTests.swift # Tests/SecureStorageTests/TestMocks.swift
samsymons
added a commit
that referenced
this pull request
Aug 20, 2023
# By Sam Symons (2) and others # Via GitHub * main: Update WireGuard version (#460) Merge Hotfix 74.0.1-1 (#465) SwiftLint fixes part 3 (#462) Moved iOS Extension to BSK (#458) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#431) feat: duck player v2 (#451) # Conflicts: # Sources/BrowserServicesKit/PrivacyConfig/AppPrivacyConfiguration.swift # Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/0/1205232831063442/f
iOS PR:
macOS PR: duckduckgo/macos-browser#1446
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL:
CC:
Description:
Please see https://app.asana.com/0/1163321984198618/1205043909152862/f
Steps to test this PR:
Please follow steps outlined here: https://app.asana.com/0/0/1205112292377078/f
Steps to test this PR:
1.
1.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template