Update NetP endpoint #456
Merged
Update NetP endpoint #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Aug 9, 2023
This was referenced Aug 9, 2023
|
@samsymons - I hope you don't mind that I edited the description to add the macOS and iOS links. |
|
@diegoreymendez Not at all, thanks! Good catch. |
diegoreymendez
approved these changes
Aug 10, 2023
samsymons
added a commit
to duckduckgo/iOS
that referenced
this pull request
Aug 13, 2023
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205234536443673/f Tech Design URL: CC: @graeme Description: This PR updates the NetP endpoint, via duckduckgo/BrowserServicesKit#456.
samsymons
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 13, 2023
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205234536443673/f Tech Design URL: CC: Description: This PR updates the NetP endpoint via duckduckgo/BrowserServicesKit#456
samsymons
added a commit
that referenced
this pull request
Aug 16, 2023
# By Sam Symons (3) and others # Via GitHub * main: Moved iOS Extension to BSK (#458) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests (#431) feat: duck player v2 (#451) Update NetP endpoint (#456) BSK SwiftLint fixes part 2: Disable some test suite warnings (#453) BSK SwiftLint fixes part 1: Autofix many SwiftLint warnings (#452) Add support for syncing Credentials (#425) Update autofill to 8.1.2 (#457) NetP - Create observers to extract from StatusReporter (#445) # Conflicts: # Sources/BookmarksTestsUtils/BookmarkTree.swift # Sources/BrowserServicesKit/Autofill/AutofillUserScript+SecureVault.swift # Sources/BrowserServicesKit/SecureVault/AutofillSecureVault.swift # Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift # Sources/BrowserServicesKit/SecureVault/SecureVaultModels.swift # Sources/BrowserServicesKit/Suggestions/Suggestion.swift # Sources/SyncDataProviders/Bookmarks/BookmarksProvider.swift # Tests/.swiftlint.yml # Tests/BrowserServicesKitTests/SecureVault/MockAutofillDatabaseProvider.swift # Tests/BrowserServicesKitTests/SecureVault/VaultFactoryTests.swift # Tests/NavigationTests/ClosureNavigationResponderTests.swift # Tests/NavigationTests/Helpers/NavigationTestHelpers.swift # Tests/NavigationTests/NavigationAuthChallengeTests.swift # Tests/SecureStorageTests/TestMocks.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205234536443673/f
iOS PR: duckduckgo/iOS#1905
macOS PR: duckduckgo/macos-browser#1459
What kind of version bump will this require?: Patch
Description:
This PR updates the NetP endpoint, see the Asana task for context.
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template