Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NetP endpoint #1905

Merged
merged 4 commits into from
Aug 13, 2023
Merged

Update NetP endpoint #1905

merged 4 commits into from
Aug 13, 2023

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1199230911884351/1205234536443673/f
Tech Design URL:
CC: @graeme

Description:

This PR updates the NetP endpoint, via duckduckgo/BrowserServicesKit#456.

Steps to test this PR:

  1. Test that NetP works

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

# By Graeme Arthur (3) and others
# Via Jacek Łyp (2) and GitHub (1)
* develop:
  Network Protection debug menu (#1910)
  Add support for syncing Credentials (#1844)
  NetP Status View Server Info + Share feedback (#1908)
  Release 7.84.0 (#1912)
  Update package resolved
  Update BSK with autofill 8.1.2 (#1909)
  Add tests to validate app config URLs (#1892)
  NetP Status View Header (#1899)
  Upgrade autoconsent to 5.3.0 (#1906)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 13, 2023
Task/Issue URL: https://app.asana.com/0/1199230911884351/1205234536443673/f
iOS PR: duckduckgo/iOS#1905
macOS PR: duckduckgo/macos-browser#1459
What kind of version bump will this require?: Patch

Description:

This PR updates the NetP endpoint, see the Asana task for context.
@samsymons samsymons merged commit 23cc2a3 into develop Aug 13, 2023
6 checks passed
@samsymons samsymons deleted the sam/netp-endpoint-change branch August 13, 2023 19:03
samsymons added a commit that referenced this pull request Aug 24, 2023
* develop: (84 commits)
  Improve Sync-related database cleaning logic (#1933)
  Fix PacketTunnelProvider embedding for Alpha builds (#1932)
  Add alpha specific app groups (#1934)
  Replaces useSystemKeychain with keychain type (#1928)
  Add Commit hook install script (#1845)
  Run checks on all PRs (#1929)
  extend valid urls to include IPv6 (#1919)
  Status view error UI (#1915)
  NetP Design Review minus errors (#1923)
  Add a GHA job to build the app in release configuration (#1848)
  Release 7.85.0 (#1926)
  Update WireGuard version (#1918)
  BSK Hotfix 74.0.1-1 (#1924)
  Post merge PR check (#1920)
  Autofill letter icons for macOS (#1911)
  Alpha build readiness (#1913)
  bump C-S-S to 4.32.0 (#1914)
  Update NetP endpoint (#1905)
  Network Protection debug menu (#1910)
  Add support for syncing Credentials (#1844)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants