Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WireGuard version #1918

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Update WireGuard version #1918

merged 4 commits into from
Aug 17, 2023

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Aug 16, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1205173072817403/f
Tech Design URL:
CC:

Description:

This PR updates the version of WireGuard used by the app.

Steps to test this PR:

  1. Check that the app builds and runs in Xcode 14, and that NetP works
  2. Do not check that the app builds and runs in Xcode 15 - there is an unrelated compilation failure which is out of scope of this PR

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons mentioned this pull request Aug 16, 2023
Merged
6 tasks
@samsymons
Merge branch 'develop' into sam/update-wireguard-framework
172dc32 
# By Daniel Bernal (1) and others
# Via GitHub
* develop:
  BSK Hotfix 74.0.1-1 (#1924)
  Post merge PR check (#1920)
  Autofill letter icons for macOS (#1911)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@samsymons
Update BSK reference.
a1f9c52
samsymons added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 17, 2023
@samsymons
Update WireGuard version (#460)
070cd52 
Required:

Task/Issue URL: https://app.asana.com/0/1203137811378537/1205173072817403/f
iOS PR: duckduckgo/iOS#1918
macOS PR: duckduckgo/macos-browser#1491
What kind of version bump will this require?: Patch

Optional:

Tech Design URL:
CC:

Description:

This PR updates the wireguard-apple repo version. The new WireGuard update includes a fix for the new linker in Xcode 15, which was preventing the macOS browser from compiling.
@samsymons samsymons merged commit 62f5950 into develop Aug 17, 2023
8 checks passed
@samsymons samsymons deleted the sam/update-wireguard-framework branch August 17, 2023 22:58
samsymons added a commit that referenced this pull request Aug 24, 2023
@samsymons
Merge branch 'develop' into sam/codeql-support
e59c6ec 
* develop: (84 commits)
  Improve Sync-related database cleaning logic (#1933)
  Fix PacketTunnelProvider embedding for Alpha builds (#1932)
  Add alpha specific app groups (#1934)
  Replaces useSystemKeychain with keychain type (#1928)
  Add Commit hook install script (#1845)
  Run checks on all PRs (#1929)
  extend valid urls to include IPv6 (#1919)
  Status view error UI (#1915)
  NetP Design Review minus errors (#1923)
  Add a GHA job to build the app in release configuration (#1848)
  Release 7.85.0 (#1926)
  Update WireGuard version (#1918)
  BSK Hotfix 74.0.1-1 (#1924)
  Post merge PR check (#1920)
  Autofill letter icons for macOS (#1911)
  Alpha build readiness (#1913)
  bump C-S-S to 4.32.0 (#1914)
  Update NetP endpoint (#1905)
  Network Protection debug menu (#1910)
  Add support for syncing Credentials (#1844)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme graeme graeme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @graeme