Fix PacketTunnelProvider embedding for Alpha builds #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
requested changes
Aug 23, 2023
|
Oh that’s weird, I could have sworn I tested this…. |
|
I see… it was working, then I tested a change to it to test out my stackoverflow answer… then I didn’t revert properly. Oops! Fixed it now I think... |
…nel-provider-embed-for-release-builds
samsymons
approved these changes
Aug 23, 2023
graeme
deleted the
graeme/fix-packet-tunnel-provider-embed-for-release-builds
branch
samsymons
added a commit
that referenced
this pull request
Aug 24, 2023
* develop: (84 commits) Improve Sync-related database cleaning logic (#1933) Fix PacketTunnelProvider embedding for Alpha builds (#1932) Add alpha specific app groups (#1934) Replaces useSystemKeychain with keychain type (#1928) Add Commit hook install script (#1845) Run checks on all PRs (#1929) extend valid urls to include IPv6 (#1919) Status view error UI (#1915) NetP Design Review minus errors (#1923) Add a GHA job to build the app in release configuration (#1848) Release 7.85.0 (#1926) Update WireGuard version (#1918) BSK Hotfix 74.0.1-1 (#1924) Post merge PR check (#1920) Autofill letter icons for macOS (#1911) Alpha build readiness (#1913) bump C-S-S to 4.32.0 (#1914) Update NetP endpoint (#1905) Network Protection debug menu (#1910) Add support for syncing Credentials (#1844) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205324333927521/f
Description:
On trying to distribute NetP through the Alpha channel, the build were being rejected by App Store Connect as their was an invalid file containing the word app. This turned out to be because the simple cp -r I was doing to move the extension was in fact not moving the extension for Archive builds, but an alias.
I had another look at the build output of Xcode’s Embed App Extensions Build Phase which uses an Xcode-internal tool builtin-copy. rsync achieves the same result and has broadly the same options. The --copy-links option is needed to resolve symlinked .appex bundles.
Edit:
This is now stacked on #1934 as its update of the provisioning profiles requires the update of Alpha entitlements
Steps to test this PR:
Products/Applications/DuckDuckGo/PlugInsand ensure thePacketTunnelProvider.appexis an actual bundle and not an alias.Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template