This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Small improvements to KeychainType.
#469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
reviewed
Aug 22, 2023
|
|
||
| /// A convenience enum to unify the logic for selecting the right keychain through the query attributes. | ||
| /// | ||
| public enum KeychainType { |
Contributor
There was a problem hiding this comment.
Nice! This will come in handy for me :)
graeme
approved these changes
Aug 22, 2023
Contributor
Author
|
Thank you @graeme ! |
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 23, 2023
Task/Issue URL: https://app.asana.com/0/0/1205112155849085/f BSK PR: duckduckgo/BrowserServicesKit#469 iOS PR: duckduckgo/iOS#1928 ## Description: Prevents launching our menu agent app without a valid NetP auth code.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Aug 23, 2023
Task/Issue URL: https://app.asana.com/0/0/1205319558799772/f BSK PR: duckduckgo/BrowserServicesKit#469 macOS PR: duckduckgo/macos-browser#1516 ## Description Changes the code so that we can specify which keychain to use. There should be no logical changes whatsoever.
samsymons
added a commit
that referenced
this pull request
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205319547453836/f
iOS PR: duckduckgo/iOS#1928
macOS PR: duckduckgo/macos-browser#1516
What kind of version bump will this require?: Patch
Description:
Small change to
KeychainTypeto make the code cleaner.Steps to test this PR:
Follow the testing steps in the macOS PR.
Internal references:
Software Engineering Expectations
Technical Design Template