This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Prevents launching our menu agent without an auth code. #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diego Rey Mendez <dreymendez@duckduckgo.com>
diegoreymendez
changed the title
diegoreymendez
requested review from
mallexxx
and removed request for
mallexxx
…thout-authcode-step1' into diego/prevent-netp-activation-without-authcode Signed-off-by: Diego Rey Mendez <dreymendez@duckduckgo.com> # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/NetworkProtectionAppEvents.swift
diegoreymendez
changed the base branch from
develop
to
diego/prevent-netp-activation-without-authcode-step1
graeme
approved these changes
Aug 22, 2023
Contributor
graeme
left a comment
graeme
left a comment
There was a problem hiding this comment.
Seems to be a bit of dead code there, but feel free to merge once removed (unless I missed something…)
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Aug 23, 2023
Task/Issue URL: https://app.asana.com/0/0/1205319547453836/f iOS PR: duckduckgo/iOS#1928 macOS PR: duckduckgo/macos-browser#1516 What kind of version bump will this require?: Patch ## Description: Small change to `KeychainType` to make the code cleaner. **Steps to test this PR**: Follow the testing steps in the macOS PR.
Base automatically changed from
diego/prevent-netp-activation-without-authcode-step1
to
develop
August 23, 2023 14:16
diegoreymendez
deleted the
diego/prevent-netp-activation-without-authcode
branch
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Aug 23, 2023
Task/Issue URL: https://app.asana.com/0/0/1205319558799772/f BSK PR: duckduckgo/BrowserServicesKit#469 macOS PR: duckduckgo/macos-browser#1516 ## Description Changes the code so that we can specify which keychain to use. There should be no logical changes whatsoever.
samsymons
added a commit
that referenced
this pull request
Aug 23, 2023
# By Diego Rey Mendez (7) and others # Via Sam Symons (2) and others * develop: (26 commits) Improve Sync-related database cleaning logic (#1529) Update onboarding-related error states (#1504) Prevents launching our menu agent without an auth code. (#1516) Autofill UI letter icons (#1535) Cleans up some code (#1517) Revert "Autofill Letter Icons" (#1534) Adds remote pre-commit installer, which includes automatic fix for linter (#1369) Autofill Letter Icons (#1475) change context menu for mailto links (#1513) Updates the version to 1.53.1 Updated the embedded files for 1.53.1 Update the phased rollout tester to avoid caching the config (#1520) Require Duck Player scheme URL to be passed from YouTube Overlay User Script (#1519) Add pixels related to Duck Player usage (#1515) only allow error reloads on http(s) urls (#1523) Standardize TDS Loading Error handling (#1524) Move pixel sender logic into the main view controller (#1528) Update the phased rollout tester to avoid caching the config (#1520) Set version to 1.52.3. Move pixel sender logic into the main view controller (#1528) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/AppDelegate/AppDelegate.swift # DuckDuckGo/Common/Localizables/UserText.swift # DuckDuckGo/Common/Utilities/UserDefaultsWrapper.swift
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205112155849085/f
BSK PR: duckduckgo/BrowserServicesKit#469
iOS PR: duckduckgo/iOS#1928
Description:
Prevents launching our menu agent app without a valid NetP auth code.
Steps to test this PR:
Before running these tests, open Keychain.app and remove all auth tokens. You'll need to enable NetP again through an invite code.
Start in
developdevelop(this is important so the auth token is not shared).DuckDuckGo AgentInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation