This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Require Duck Player scheme URL to be passed from YouTube Overlay User Script #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Aug 21, 2023
Collaborator
samsymons
left a comment
samsymons
left a comment
There was a problem hiding this comment.
LGTM! I hit the assertion failure as expected, and the rest of Duck Player is working as intended.
samsymons
added a commit
that referenced
this pull request
Aug 22, 2023
# By Diego Rey Mendez (3) and others # Via Diego Rey Mendez (1) and GitHub (1) * develop: Require Duck Player scheme URL to be passed from YouTube Overlay User Script (#1519) extend valid urls to include IPv6 (#1492) Fix bug where Back navigation doesn't work properly with bangs (#1510) remove logic to keep previous search mode (#1500) Bump version to 1.53.0 (52) Update embedded files Adds a file that's generated when the unit tests are run (#1511) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
diegoreymendez
pushed a commit
that referenced
this pull request
Aug 23, 2023
… Script (#1519) Task/Issue URL: https://app.asana.com/0/0/1205318681239304/f Description: Validate the message and return early if the passed URL is different than duck://....
samsymons
added a commit
that referenced
this pull request
Aug 23, 2023
# By Diego Rey Mendez (7) and others # Via Sam Symons (2) and others * develop: (26 commits) Improve Sync-related database cleaning logic (#1529) Update onboarding-related error states (#1504) Prevents launching our menu agent without an auth code. (#1516) Autofill UI letter icons (#1535) Cleans up some code (#1517) Revert "Autofill Letter Icons" (#1534) Adds remote pre-commit installer, which includes automatic fix for linter (#1369) Autofill Letter Icons (#1475) change context menu for mailto links (#1513) Updates the version to 1.53.1 Updated the embedded files for 1.53.1 Update the phased rollout tester to avoid caching the config (#1520) Require Duck Player scheme URL to be passed from YouTube Overlay User Script (#1519) Add pixels related to Duck Player usage (#1515) only allow error reloads on http(s) urls (#1523) Standardize TDS Loading Error handling (#1524) Move pixel sender logic into the main view controller (#1528) Update the phased rollout tester to avoid caching the config (#1520) Set version to 1.52.3. Move pixel sender logic into the main view controller (#1528) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/AppDelegate/AppDelegate.swift # DuckDuckGo/Common/Localizables/UserText.swift # DuckDuckGo/Common/Utilities/UserDefaultsWrapper.swift
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205318681239304/f
Description:
Validate the message and return early if the passed URL is different than
duck://....Steps to test this PR:
Refer to the linked Asana task for testing steps. There is a test build attached that you could use.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation