This repository was archived by the owner on Feb 24, 2025. It is now read-only.
remove logic to keep previous search mode #1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
added a commit
that referenced
this pull request
Aug 22, 2023
# By Diego Rey Mendez (3) and others # Via Diego Rey Mendez (1) and GitHub (1) * develop: Require Duck Player scheme URL to be passed from YouTube Overlay User Script (#1519) extend valid urls to include IPv6 (#1492) Fix bug where Back navigation doesn't work properly with bangs (#1510) remove logic to keep previous search mode (#1500) Bump version to 1.53.0 (52) Update embedded files Adds a file that's generated when the unit tests are run (#1511) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1202319845644422/f
Description: at the moment when we do a search we keep the previous search mode for example images. This behaviour differs from other platform and we want to remove it.
Steps to test this PR:
<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the
DO NOT MERGElabel (particularly if it's a draft)If it's pending Product Review/PFR, please add the
Pending Product Reviewlabel.If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation