This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Fix bug where Back navigation doesn't work properly with bangs #1510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mallexxx
requested review from
SabrinaTardio
and removed request for
tomasstrba
Collaborator
SabrinaTardio
left a comment
SabrinaTardio
left a comment
There was a problem hiding this comment.
Thank you so much for fixing this… Works great beside one case… if you do the search from the home page it will still try to navigate back to the search while the back button should be disabled.
Collaborator
Author
|
@SabrinaTardio this is an old known issue.. should be fixed now, please check (TBD: add a new private API to the "used" list) |
samsymons
added a commit
that referenced
this pull request
Aug 22, 2023
# By Diego Rey Mendez (3) and others # Via Diego Rey Mendez (1) and GitHub (1) * develop: Require Duck Player scheme URL to be passed from YouTube Overlay User Script (#1519) extend valid urls to include IPv6 (#1492) Fix bug where Back navigation doesn't work properly with bangs (#1510) remove logic to keep previous search mode (#1500) Bump version to 1.53.0 (52) Update embedded files Adds a file that's generated when the unit tests are run (#1511) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1503
Task/Issue URL: https://app.asana.com/0/1177771139624306/1204176861755199/f
CC: @SabrinaTardio
Description: When navigating back after using a back it gets stuck in a redirection loop. As a hack fix it checks wether the URL we are about to navigate to is a search with bang, if so navigates 2 positions back. The same happens forward.
Also it removes search with bang items from the context menu of the back/forward buttons.
Steps to test this PR:
!bangfrom a new tab - no back item is createdInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation