This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Adds a file that's generated when the unit tests are run #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
approved these changes
Aug 21, 2023
Collaborator
ayoy
left a comment
ayoy
left a comment
There was a problem hiding this comment.
LGTM, all tests are passing locally for both targets for me 👍
diegoreymendez
deleted the
diego/fix-waitlist-beta-unit-tests-creating-file
branch
samsymons
added a commit
that referenced
this pull request
Aug 22, 2023
# By Diego Rey Mendez (3) and others # Via Diego Rey Mendez (1) and GitHub (1) * develop: Require Duck Player scheme URL to be passed from YouTube Overlay User Script (#1519) extend valid urls to include IPv6 (#1492) Fix bug where Back navigation doesn't work properly with bangs (#1510) remove logic to keep previous search mode (#1500) Bump version to 1.53.0 (52) Update embedded files Adds a file that's generated when the unit tests are run (#1511) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205311594925819/f
Description:
Adds a file that's generated by our unit tests that's causing fastlane to fail.
Steps to test this PR:
Ensure no new file is created, and there are no modifications to existing files.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation