Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add messaging contract for duck player page #1003

Merged
merged 3 commits into from
Aug 1, 2024
Merged

add messaging contract for duck player page #1003

merged 3 commits into from
Aug 1, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jul 31, 2024 •
edited
Loading

https://app.asana.com/0/1201141132935289/1207942137400006/f

These are the schema files used by DuckPlayer - split out here for easier review.

This was referenced Jul 31, 2024
Merged
Merged
@shakyShane
Copy link
Contributor Author

shakyShane commented Jul 31, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane mentioned this pull request Jul 31, 2024
Merged
2 tasks
@shakyShane shakyShane marked this pull request as ready for review July 31, 2024 15:17
@github-actions GitHub Actions
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

mgurgel
mgurgel previously approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two questions, but looks good otherwise!

Base automatically changed from shane/duckplayer-android-testing-support to main July 31, 2024 16:36
@shakyShane shakyShane dismissed mgurgel’s stale review July 31, 2024 16:36

The base branch was changed.

@shakyShane shakyShane force-pushed the shane/duckplayer-message-contracts branch from 28d644c to e480031 Compare July 31, 2024 16:36
@github-actions GitHub Actions
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane merged commit 598faa7 into main Aug 1, 2024
6 checks passed
@shakyShane shakyShane deleted the shane/duckplayer-message-contracts branch August 1, 2024 09:35
@shakyShane shakyShane mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgurgel mgurgel mgurgel left review comments

@jonathanKingston jonathanKingston Awaiting requested review from jonathanKingston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakyShane @mgurgel