implement next version of Duck Player #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on |
shakyShane
force-pushed
the
shane/duckplayer-next
branch
from
efc8e64 to
4b418a9
Compare
shakyShane
force-pushed
the
shane/duckplayer-message-contracts
branch
from
28d644c to
e480031
Compare
shakyShane
force-pushed
the
shane/duckplayer-next
branch
2 times, most recently
from
07c993e to
2633484
Compare
shakyShane
force-pushed
the
shane/duckplayer-next
branch
2 times, most recently
from
95689e2 to
c4f5e9e
Compare
shakyShane
force-pushed
the
shane/duckplayer-next
branch
from
a594582 to
d369580
Compare
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
shakyShane
force-pushed
the
shane/duckplayer-next
branch
from
e562912 to
0fa5330
Compare
shakyShane
changed the base branch from
main
to
08-09-naming_use_injectname_vs_platform_in_the_correct_places
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
Base automatically changed from
08-09-naming_use_injectname_vs_platform_in_the_correct_places
to
main
August 9, 2024 12:20
added 9 commits
August 9, 2024 13:20
shakyShane
force-pushed
the
shane/duckplayer-next
branch
from
a0cd95c to
a7b6347
Compare
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1201141132935289/1207942137400007/f
This is DuckPlayer as components, with the following core changes:
1 - schema based messaging
2 - full support for mobile layouts
3 - full support for localization
4 - better error handling
5 - lots more tests, covering every feature now
6 - some added screenshots to ensure the UI cannot regress
Note: I'm not happy with the lack of css custom properties for brand stuff, nor the heavy use of px-based values. However, given the scale of the change, I'm opting for adding screenshots this time around, allowing us to refactor the CSS later.
Note: This initial merge is to enable the desktop variants to ship - so we can restrict manual testing to macOS + Windows