Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flakiness from release-notes tests #1005

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Aug 1, 2024

The release-notes integration tests became flaky - even failing sometimes locally.

With retries in CI they would pass, but it was unpredictable. This fixes it.

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane marked this pull request as ready for review August 1, 2024 09:54
@shakyShane shakyShane requested a review from mgurgel August 1, 2024 09:54
Copy link

github-actions bot commented Aug 1, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

Copy link

github-actions bot commented Aug 1, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane merged commit 05799cd into main Aug 1, 2024
6 checks passed
@shakyShane shakyShane deleted the 08-01-remove_flakiness_from_release-notes_tests branch August 1, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants