Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flakiness from release-notes tests #1005

Merged
merged 2 commits into from
Aug 1, 2024
Merged

remove flakiness from release-notes tests #1005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d4d548
remove flakiness from release-notes tests
Aug 1, 2024
45d0583
Merge branch 'main' into 08-01-remove_flakiness_from_release-notes_tests
mgurgel Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/special-pages/tests/page-objects/release-notes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@ export class ReleaseNotesPage {
* @param {boolean} [options.privacyPro]
*/
async sendSubscriptionMessage (messageType, options) {
// Wait for the subscription handler to appear before trying to simulate push events.
// This prevents a race condition where playwright is sending data before `.subscribe` was called
await this.page.waitForFunction(() => 'onUpdate' in window && typeof window.onUpdate === 'function')

const data = options?.privacyPro
? { ...sampleData[messageType] }
: { ...sampleData[messageType], releaseNotesPrivacyPro: null }
Expand Down
Loading