added locale strings for DuckPlayer #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for release-notes-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on |
shakyShane
changed the title
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
shakyShane
commented
Sep 9, 2024
| "bundle-config": "node scripts/bundleConfig.mjs", | ||
| "build": "npm run build-locales && npm run build-types && npm run bundle-trackers && npm run build-firefox && npm run build-chrome && npm run build-apple && npm run build-android && npm run build-windows && npm run build-integration && npm run build-chrome-mv3", | ||
| "build-locales": "node scripts/buildLocales.js --dir src/locales/click-to-load --output build/locales/ctl-locales.js", | ||
| "build-locales": "node scripts/buildLocales.js", |
There was a problem hiding this comment.
I moved this configuration into the script - so instead of the flags, we just list out all the projects requiring the bundled translations
shakyShane
commented
Sep 9, 2024
Comment on lines
+44
to
+57
| // This will be re-enabled in the mobile PR | ||
| // const strings = environment.locale === 'en' | ||
| // ? enStrings | ||
| // : await fetch(`./locales/${environment.locale}/duckplayer.json`) | ||
| // .then(resp => { | ||
| // if (!resp.ok) { | ||
| // throw new Error('did not give a result') | ||
| // } | ||
| // return resp.json() | ||
| // }) | ||
| // .catch(e => { | ||
| // console.error('Could not load locale', environment.locale, e) | ||
| // return enStrings | ||
| // }) |
There was a problem hiding this comment.
This gets re-enabled later when we support mobile - but by removing it here, we can merge these strings in without risking untested UI hitting prod
mallexxx
pushed a commit
that referenced
this pull request
Jul 17, 2025
* added locale strings for duckplayer * limit localization to none-desktop * drop dynamic strings for this PR --------- Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1201141132935289/1208258427490256/f
What was added
What was changed
package.jsonscript , because we now have more than 1 feature using the bundled strings