Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshots for the duckplayer overlay #1030

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Sep 9, 2024

https://app.asana.com/0/1201141132935289/1208258427491326/f

  • Added a screenshot test for the Overlays.
  • They are 'disabled' by default, to prevent none-FE folk from having to run them
  • They will get enabled in CI shortly once we've been through a TD with other CSS folk.

@shakyShane
Copy link
Contributor Author

shakyShane commented Sep 9, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane marked this pull request as ready for review September 9, 2024 12:12
Copy link

github-actions bot commented Sep 9, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Sep 9, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane force-pushed the shane/duckplayer-android branch from 609dd57 to 0af7c82 Compare September 9, 2024 13:21
@shakyShane shakyShane force-pushed the shane/duckplayer-screenshots branch from b110d73 to 789c2a5 Compare September 9, 2024 13:21
Copy link

github-actions bot commented Sep 9, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

package.json Show resolved Hide resolved
@shakyShane shakyShane force-pushed the shane/duckplayer-android branch from 0af7c82 to d0efe95 Compare September 9, 2024 13:38
@shakyShane shakyShane force-pushed the shane/duckplayer-screenshots branch from 789c2a5 to 7c2133e Compare September 9, 2024 13:38
Copy link

github-actions bot commented Sep 9, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

mgurgel
mgurgel previously approved these changes Sep 9, 2024
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Base automatically changed from shane/duckplayer-android to main September 9, 2024 14:10
@shakyShane shakyShane dismissed mgurgel’s stale review September 9, 2024 14:10

The base branch was changed.

@shakyShane shakyShane force-pushed the shane/duckplayer-screenshots branch from 7c2133e to efdf26c Compare September 9, 2024 14:10
Copy link

github-actions bot commented Sep 9, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane merged commit e29d271 into main Sep 9, 2024
6 checks passed
@shakyShane shakyShane deleted the shane/duckplayer-screenshots branch September 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants