ntp: stats feedback #1098
Merged
ntp: stats feedback #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
shakyShane
force-pushed
the
10-11-ntp_stats_feedback
branch
from
5527bec to
df17720
Compare
shakyShane
commented
Oct 14, 2024
packages/special-pages/pages/new-tab/app/privacy-stats/PrivacyStatsProvider.js
Outdated
Show resolved
Hide resolved
shakyShane
commented
Oct 14, 2024
shakyShane
commented
Oct 14, 2024
mgurgel
previously approved these changes
Oct 14, 2024
shakyShane
force-pushed
the
10-11-ntp_stats_feedback
branch
from
2586f6e to
fdba2a4
Compare
shakyShane
commented
Oct 15, 2024
shakyShane
force-pushed
the
10-11-ntp_stats_feedback
branch
from
f5de858 to
a87379f
Compare
|
Verified this is not impacting any production code. |
vkraucunas
pushed a commit
that referenced
this pull request
Oct 17, 2024
* ntp: stats feedback * deps * move esbuild dependency into special-pages --------- Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1208541017100691/f
Preview: https://10-11-ntp-stats-feedback--harmonious-stardust-3b22ba.netlify.app/
Description
I back-ported a bunch of changes that were made to support favorites too - which is why the PR is a little larger than expected.
The main change (seen in the Preview link) is that we're defaulting to auto-animations for now - and we've added an easy way to configure that.
Testing Steps
Checklist
Please tick all that apply: