Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favorites drag and drop #1091

Closed
wants to merge 1 commit into from
Closed

Conversation

shakyShane
Copy link
Contributor

favorites drag and drop

animate with view transition if available

POC

make favorites mockable

This was referenced Oct 5, 2024
@shakyShane
Copy link
Contributor Author

shakyShane commented Oct 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Oct 5, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch 7 times, most recently from 6147afa to 3e67f73 Compare October 7, 2024 12:08
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 331d9c5 to 8dbf1e3 Compare October 10, 2024 06:55
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from f88e6ab to 0358242 Compare October 10, 2024 06:55
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 8dbf1e3 to 57755d8 Compare October 10, 2024 10:16
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from 0358242 to 53f8a04 Compare October 10, 2024 10:16
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 57755d8 to 04d475e Compare October 10, 2024 11:59
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from 53f8a04 to 3d2a942 Compare October 10, 2024 11:59
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 04d475e to 5adcb29 Compare October 10, 2024 13:26
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from 3d2a942 to 650db71 Compare October 10, 2024 13:26
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 5adcb29 to 01108d2 Compare October 10, 2024 13:54
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch 2 times, most recently from 41a6cff to a09f19d Compare October 10, 2024 16:15
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from d02f2dd to 41a640b Compare October 10, 2024 16:25
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from a09f19d to f067d7f Compare October 10, 2024 16:25
@shakyShane shakyShane force-pushed the 09-25-ntp_privacy_stats_widget branch from 41a640b to d2dd18e Compare October 10, 2024 16:27
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from f067d7f to 81fcd4e Compare October 10, 2024 16:27
Base automatically changed from 09-25-ntp_privacy_stats_widget to main October 10, 2024 16:34
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch 2 times, most recently from eca9943 to d9c584e Compare October 10, 2024 19:26
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from d9c584e to a6fd339 Compare October 11, 2024 08:49
@shakyShane shakyShane changed the base branch from main to 10-11-ntp_stats_feedback October 11, 2024 08:49
@shakyShane shakyShane mentioned this pull request Oct 11, 2024
8 tasks
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch 2 times, most recently from eab58f2 to 847dcaa Compare October 11, 2024 10:16
@shakyShane shakyShane force-pushed the 10-11-ntp_stats_feedback branch from 5527bec to df17720 Compare October 13, 2024 08:40
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch 4 times, most recently from 3b423d8 to 66c4e38 Compare October 15, 2024 06:02
@shakyShane shakyShane force-pushed the 10-11-ntp_stats_feedback branch from 2586f6e to fdba2a4 Compare October 15, 2024 20:28
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch 2 times, most recently from 0dc8afd to 9c73393 Compare October 15, 2024 20:31
@shakyShane shakyShane force-pushed the 10-11-ntp_stats_feedback branch from f5de858 to a87379f Compare October 16, 2024 15:35
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from 9c73393 to 37fb296 Compare October 16, 2024 15:35
Base automatically changed from 10-11-ntp_stats_feedback to main October 16, 2024 15:45
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from 37fb296 to 3c9a2e7 Compare October 17, 2024 12:02
Copy link

github-actions bot commented Oct 17, 2024

[Beta] Generated file diff

Time updated: Mon, 21 Oct 2024 11:54:50 GMT

Integration
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/locales/en/newtab.json

File has changed

Windows
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/locales/en/newtab.json

File has changed

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for content-scope-scripts failed.

Name Link
🔨 Latest commit a56e8ea
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/671640296797430008a3cadb

@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from 5435924 to ed057dc Compare October 21, 2024 10:58
@shakyShane shakyShane force-pushed the 10-04-favorites_drag_and_drop branch from ed057dc to a56e8ea Compare October 21, 2024 11:51
@shakyShane shakyShane mentioned this pull request Oct 21, 2024
8 tasks
@shakyShane shakyShane closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant