Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move remaining tests to playwright #1089

Merged
merged 8 commits into from
Oct 10, 2024
Merged

move remaining tests to playwright #1089

merged 8 commits into from
Oct 10, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Oct 3, 2024 •
edited
Loading

https://app.asana.com/0/1201614831475344/1206978084282840/f

I've done this on top of removing runtimeChecks #1066

@shakyShane shakyShane marked this pull request as ready for review October 3, 2024 21:47
@shakyShane
Copy link
Contributor Author

shakyShane commented Oct 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane force-pushed the jkt/unship-runtime-checks branch from 0734468 to 234875e Compare October 3, 2024 21:48
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from 2134817 to a50c481 Compare October 3, 2024 21:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane mentioned this pull request Oct 4, 2024
Merged
3 tasks
@shakyShane shakyShane force-pushed the jkt/unship-runtime-checks branch from 234875e to 5f1b514 Compare October 4, 2024 14:50
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from 2d3b811 to 799e2ff Compare October 4, 2024 14:50
@shakyShane shakyShane mentioned this pull request Oct 4, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from 799e2ff to 17612a2 Compare October 4, 2024 15:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane force-pushed the jkt/unship-runtime-checks branch from a0c334d to 30108f1 Compare October 4, 2024 19:20
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from 17612a2 to cb9eeab Compare October 4, 2024 19:20
@shakyShane shakyShane mentioned this pull request Oct 5, 2024
Closed
@jonathanKingston jonathanKingston force-pushed the jkt/unship-runtime-checks branch from 2a7d7c6 to 327e3e4 Compare October 10, 2024 09:58
Base automatically changed from jkt/unship-runtime-checks to main October 10, 2024 10:13
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from 2f73d83 to a917295 Compare October 10, 2024 10:16
@shakyShane shakyShane force-pushed the 10-01-move_tests_to_playwright branch from a917295 to 27a1689 Compare October 10, 2024 11:59
@jonathanKingston jonathanKingston self-requested a review October 10, 2024 13:42
@jonathanKingston
Copy link
Contributor

Cheers for doing this, remember to raise the few tasks we discussed:

  • moving pupeteer dir
  • consider simplifying altServerPort + server.mjs / make function task.

@shakyShane shakyShane merged commit c023ec0 into main Oct 10, 2024
6 checks passed
@shakyShane shakyShane deleted the 10-01-move_tests_to_playwright branch October 10, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muodov muodov muodov left review comments

@jonathanKingston jonathanKingston jonathanKingston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shakyShane @jonathanKingston @muodov