Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove runtime-checks #1066

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Remove runtime-checks #1066

merged 3 commits into from
Oct 10, 2024

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Sep 19, 2024 •
edited
Loading

Task: https://app.asana.com/0/1201614831475344/1208341763117531/f

Removes the runtime-checks feature and all it's related features.

@jonathanKingston jonathanKingston force-pushed the jkt/unship-runtime-checks branch from d631430 to ab41de3 Compare September 19, 2024 00:42
@github-actions GitHub Actions
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@jonathanKingston jonathanKingston force-pushed the jkt/unship-runtime-checks branch from ab41de3 to 0734468 Compare September 19, 2024 00:50
@github-actions GitHub Actions
Copy link

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

shakyShane
shakyShane previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havn't checked if there's anything missing, but the tests are passing and it lgtm.

@jonathanKingston jonathanKingston marked this pull request as draft September 19, 2024 07:12
@shakyShane shakyShane mentioned this pull request Oct 3, 2024
Merged
@shakyShane shakyShane force-pushed the jkt/unship-runtime-checks branch from 0734468 to 234875e Compare October 3, 2024 21:48
@shakyShane
Copy link
Contributor

@jonathanKingston just a heads-up that I already updated this branch with main, so that I could build off it.

@shakyShane shakyShane mentioned this pull request Oct 4, 2024
Merged
3 tasks
@shakyShane shakyShane force-pushed the jkt/unship-runtime-checks branch from 234875e to 5f1b514 Compare October 4, 2024 14:50
@shakyShane
Copy link
Contributor

shakyShane commented Oct 4, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jonathanKingston and the rest of your teammates on Graphite Graphite

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane force-pushed the jkt/unship-runtime-checks branch from a0c334d to 30108f1 Compare October 4, 2024 19:20
@shakyShane shakyShane changed the title POC remove runtime-checks Remove runtime-checks Oct 4, 2024
@shakyShane shakyShane marked this pull request as ready for review October 4, 2024 19:27
@shakyShane shakyShane mentioned this pull request Oct 5, 2024
Closed
@jonathanKingston jonathanKingston force-pushed the jkt/unship-runtime-checks branch from 2a7d7c6 to 327e3e4 Compare October 10, 2024 09:58
shakyShane
shakyShane approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jonathanKingston jonathanKingston merged commit f99315b into main Oct 10, 2024
6 checks passed
@jonathanKingston jonathanKingston deleted the jkt/unship-runtime-checks branch October 10, 2024 10:13
@jonathanKingston jonathanKingston mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane shakyShane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathanKingston @shakyShane