Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteMessagingFramework component #1114

Merged
merged 40 commits into from
Oct 25, 2024
Merged

RemoteMessagingFramework component #1114

merged 40 commits into from
Oct 25, 2024

Conversation

vkraucunas
Copy link
Contributor

@vkraucunas vkraucunas commented Oct 16, 2024 •
edited by shakyShane
Loading

Asana Task/Github Issue:
Link to Asana Task/Github Issue

Description

  • Adds a RemoteMessagingFramework component to the New Tab Page

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@vkraucunas vkraucunas changed the title WIP RemoteMessagingFramework component [WIP] RemoteMessagingFramework component Oct 17, 2024
@vkraucunas vkraucunas marked this pull request as draft October 17, 2024 05:31
@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 8e42da9
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/671ba96f8cd82e0008452152
😎 Deploy Preview https://deploy-preview-1114--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

This was referenced Oct 18, 2024
Closed
Closed
@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-remotemessagingframwork-fe branch from ac3c681 to 2f1d435 Compare October 19, 2024 03:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 19, 2024 •
edited
Loading

[Beta] Generated file diff

Time updated: Fri, 25 Oct 2024 14:22:40 GMT

Integration 
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/js/mock-transport.js
  • integration/pages/release-notes/js/index.js
  • integration/pages/special-error/js/index.js

File has changed

Windows 
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/js/mock-transport.js

File has changed

Apple 
    - dist/pages/release-notes/js/index.js
  • dist/pages/special-error/index.html
  • dist/pages/special-error/js/index.js

File has changed

New Files 
    - integration/pages/new-tab/icons/Announce.svg
  • integration/pages/new-tab/icons/AppUpdate.svg
  • integration/pages/new-tab/icons/CriticalUpdate.svg
  • integration/pages/new-tab/icons/DDGAnnounce.svg
  • integration/pages/new-tab/icons/PrivacyPro.svg
  • windows/pages/new-tab/icons/Announce.svg
  • windows/pages/new-tab/icons/AppUpdate.svg
  • windows/pages/new-tab/icons/CriticalUpdate.svg
  • windows/pages/new-tab/icons/DDGAnnounce.svg
  • windows/pages/new-tab/icons/PrivacyPro.svg

❌ File only exists in new changeset

@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-remotemessagingframwork-fe branch from 37cc1be to f568272 Compare October 22, 2024 03:26
@vkraucunas vkraucunas marked this pull request as ready for review October 22, 2024 04:48
@vkraucunas vkraucunas requested a review from a team as a code owner October 22, 2024 04:48
@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-remotemessagingframwork-fe branch from 001879b to e5aa42a Compare October 22, 2024 19:57
@shakyShane shakyShane force-pushed the vkraucunas/ntp-remotemessagingframwork-fe branch from c0466d3 to 5c707b4 Compare October 23, 2024 13:25
@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-remotemessagingframwork-fe branch from a1a5cd2 to 67e0c35 Compare October 24, 2024 01:27
@shakyShane
Copy link
Contributor

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vkraucunas and the rest of your teammates on Graphite Graphite

@vkraucunas vkraucunas force-pushed the vkraucunas/ntp-remotemessagingframwork-fe branch from 41ff0d8 to 3fab1d5 Compare October 24, 2024 18:50
vkraucunas and others added 22 commits October 24, 2024 21:15
@vkraucunas
chore: Complete dark mode styles
953a03b
re-use a json schema type for icons
2b335ee
@vkraucunas
trying to not regress Examples.jsx
8bb1419
@vkraucunas
chore: Improve rmf example on new-tab route
5fdc055
@vkraucunas
chore: Add tests for RMF
579df6f
@vkraucunas
fix(attempt): Added an rmfParam to ntp.openPage method
a005adf
@vkraucunas
feat: Added type to shared Button component
7861e62
rmf: removed configurability + fixed tests
9afe9cb
support widgets without config
2f1bccc
added primary action
25e1b5c
lint
c8bc344
@vkraucunas
chore: Add dismiss and secondaryAction
2b57ca7
@vkraucunas
fix: after rebase
29f454e
@vkraucunas
fix: RMF test
a0e6b21
@vkraucunas
fix: RMF test
28bcf02
@vkraucunas
chore: Add the show/hide functionality for the dismissBtn commented o…
c8e45b6 
…ut in the CSS
@vkraucunas
fix: Add focus visible css for dismiss btn
34811f7
@vkraucunas
fix: Dismiss btn colors
41131b2
extract mock data and inert svgs
eaff43b
@vkraucunas
chore: Rm the show/hide code for dismissBtn, update focus ring
f00f0dc
@vkraucunas
fix: Line height messing with inbetween spacing
1b5c1b8
updated tests
babee23
@shakyShane shakyShane force-pushed the vkraucunas/ntp-remotemessagingframwork-fe branch from 3fab1d5 to babee23 Compare October 24, 2024 20:29
@shakyShane shakyShane changed the title [WIP] RemoteMessagingFramework component RemoteMessagingFramework component Oct 25, 2024
shakyShane
shakyShane approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@shakyShane shakyShane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vkraucunas.

Since this wont be used just yet (but has been design reviewed), let's merge it now and follow up with docs (to keep the PR smaller)

@shakyShane shakyShane merged commit 8f0a8bd into main Oct 25, 2024
16 checks passed
@shakyShane shakyShane deleted the vkraucunas/ntp-remotemessagingframwork-fe branch October 25, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakyShane shakyShane shakyShane approved these changes

@mgurgel mgurgel Awaiting requested review from mgurgel mgurgel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkraucunas @shakyShane @jonathanKingston